Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: Move to using separated repository #855

Merged
merged 1 commit into from Sep 25, 2017

Conversation

cmeister2
Copy link
Contributor

The curl fuzzer has been moved into its own repository,
http://github.com/curl/curl-fuzzer. For oss-fuzz this means it needs to
check out two codebases and compile them.


Tagging @bagder as curl owner. I've tested this locally and it works the same as the old code.

The curl fuzzer has been moved into its own repository,
http://github.com/curl/curl-fuzzer. For oss-fuzz this means it needs to
check out two codebases and compile them.
@Dor1s
Copy link
Contributor

Dor1s commented Sep 25, 2017

May I ask you why the fuzzer has been moved from the main repository?

We encourage tight integration of fuzz testing with projects being tested, so this particular change looks like a downgrade rather than an improvement...

@cmeister2
Copy link
Contributor Author

Certainly you may. I wanted to commit the autogenerated corpus to the repository so that other people had a basis for starting fuzzing with separate engines (for example). The project lead @bagder rejected that, and suggested we split the project off. See curl/curl#1905 for discussion.

We won't end up losing integration here. The fuzzer CI automatically gets the latest curl master and checks against that for all PRs. This pull request will ensure that the fuzzer is still part of the curl CI, so fuzzing will still take place for all curl PRs. Essentially both projects are linked and dependent upon one another.

There's also a question of permissions; I'm currently driving this fuzzing effort but I don't have write access to the main curl project. I do have write access to curl-fuzzer, so I'm more easily able to add new fuzzing coverage cases without having to get them reviewed explicitly by @bagder.

@Dor1s
Copy link
Contributor

Dor1s commented Sep 25, 2017

That makes total sense, thank you @cmeister2!

@Dor1s Dor1s merged commit bf16050 into google:master Sep 25, 2017
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
The curl fuzzer has been moved into its own repository,
http://github.com/curl/curl-fuzzer. For oss-fuzz this means it needs to
check out two codebases and compile them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants