internal/driver: fix new unkeyed composite lit vet warnings #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of go vet does not flag these as noted in golang/go#23539. A fix is in the works, and will likely be included in Go 1.11. Make the updated vet tool happy, so that the vendored copy of pprof in the Go tree can be updated and make the vet trybot happy. Fixes #297.
aalexand
approved these changes
Jan 25, 2018
aalexand
approved these changes
Jan 25, 2018
lannadorai
pushed a commit
to lannadorai/pprof
that referenced
this pull request
Feb 13, 2018
The current version of go vet does not flag these as noted in golang/go#23539. A fix is in the works, and will likely be included in Go 1.11. Make the updated vet tool happy, so that the vendored copy of pprof in the Go tree can be updated and make the vet trybot happy. Fixes google#297.
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
The current version of go vet does not flag these as noted in golang/go#23539. A fix is in the works, and will likely be included in Go 1.11. Make the updated vet tool happy, so that the vendored copy of pprof in the Go tree can be updated and make the vet trybot happy. Fixes google#297.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of go vet does not flag these as noted in
golang/go#23539. A fix is in the works, and will likely be included in
Go 1.11. Make the updated vet tool happy, so that the vendored copy of
pprof in the Go tree can be updated and make the vet trybot happy.
Fixes #297.