Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReadonlyMessageMixin #183

Closed
szakarias opened this issue Jan 17, 2019 · 1 comment · Fixed by #644
Closed

Remove ReadonlyMessageMixin #183

szakarias opened this issue Jan 17, 2019 · 1 comment · Fixed by #644
Assignees
@szakarias

Comments

@szakarias
Copy link
Member

No description provided.

@szakarias szakarias self-assigned this Jan 17, 2019
@sigurdm
Copy link
Collaborator

sigurdm commented Jan 17, 2019

Seems to be unused internally, and is no longer used by the generated code.

osa1 added a commit to osa1/protobuf.dart that referenced this issue May 10, 2022
@osa1
Remove ReadonlyMessageMixin
615d8e2 
This mixin is not used internally. On GitHub there are references to
this symbol, but they are all either (1) copies/forks of this library
(2) old protoc_plugin-generated code. So removing this shouldn't cause
any issues.

Closes google#183
@osa1 osa1 mentioned this issue May 10, 2022
Merged
@osa1 osa1 closed this as completed in #644 Jun 15, 2022
osa1 added a commit that referenced this issue Jun 15, 2022
@osa1
Remove ReadonlyMessageMixin (#644)
e716334 
This mixin is not used internally. On GitHub there are references to
this symbol, but they are all either (1) copies/forks of this library
(2) old protoc_plugin-generated code. So removing this shouldn't cause
any issues.

Closes #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szakarias szakarias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ReadonlyMessageMixin osa1/protobuf.dart
2 participants
@szakarias @sigurdm