Allow generating move constructors and operators using cpp_opt=cxx11 #316

Closed
wants to merge 0 commits into
from

Conversation

Projects
None yet
6 participants

romange commented Apr 29, 2015

No description provided.

Collaborator

googlebot commented Apr 29, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no label Apr 29, 2015

romange commented Apr 29, 2015

I signed it!

On Wed, Apr 29, 2015 at 12:04 PM, googlebot notifications@github.com
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#316 (comment).

Best regards,
Roman

Collaborator

googlebot commented Apr 29, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 29, 2015

Member

xfxyjwf commented Jun 6, 2015

Thanks for the change, but we probably could not proceed with it before some internal issues are resolved. Internally there is a proposal to make protobuf's movable but so far the proposal has not been approved yet. Before that is resolved, we will not add any support for move semantics in the library.

+1

haberman added the wontfix label Feb 17, 2016

Collaborator

grpc-jenkins commented Apr 11, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

romange closed this Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment