Allows the Ruby json marshaller to be passed json marshal options #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
ebenoist
changed the title
|
Fixes #4052 as well |
|
This is a simple change that complies better with Ruby's native What is the process to get a review of this change? |
|
ping @TeBoring |
1 similar comment
|
ping @TeBoring |
TeBoring
approved these changes
May 21, 2018
TeBoring
pushed a commit
to TeBoring/protobuf
that referenced
this pull request
May 25, 2018
carsol
pushed a commit
to carsol/gcr
that referenced
this pull request
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON marshaller accepts both the preseve_field_names and emit_defaults options in the C bindings, but these options are not easily exposed to the Ruby encode/decode methods. This PR adds an options hash, empty by default, that can be used to pass options at runtime.