Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal ios and osx version for deployment. #635

Merged
merged 1 commit into from Jul 27, 2015

Conversation

TeBoring
Copy link
Contributor

No description provided.

@TeBoring
Copy link
Contributor Author

@jcanizales to review

@jcanizales
Copy link
Contributor

LGTM, but I'd have @thomasvl and @dmaclach review, because "deployment target" and "base SDK" still confuse me. For example, I see on Apple's documentation that nullable, nonnull etc. are supported starting with XCode 6.3, but I can't make the link between that and iOS version. It sounds more like a feature of clang, and they do say the ABI of the files doesn't change by using them.

@TeBoring
Copy link
Contributor Author

@thomasvl
Copy link
Contributor

Bo - As you point out, the project is set to iOS 7.1, but you made the podspec 8.0, why the difference?

@TeBoring
Copy link
Contributor Author

I was going to change it to 7.1. Just waited for confirmation.

TeBoring added a commit that referenced this pull request Jul 27, 2015
Update minimal ios and osx version for deployment.
@TeBoring TeBoring merged commit f642c5c into protocolbuffers:master Jul 27, 2015
@TeBoring TeBoring deleted the objectivec branch July 27, 2015 18:43
taoso pushed a commit to taoso/protobuf that referenced this pull request Aug 1, 2018
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
…ss, compiles with strictNullChecks by default now, see protocolbuffers#635; Docs: Added SVG logo, see protocolbuffers#629; Other: Minor codegen enhancements
adellahlou pushed a commit to adellahlou/protobuf that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants