Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Update for spec v0.26 #30
Conversation
azerupi
added some commits
Aug 3, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
Aug 5, 2016
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
googlebot
commented
Aug 5, 2016
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed, please reply here (e.g.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I signed it! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
commented
Aug 5, 2016
|
CLAs look good, thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
raphlinus
Aug 5, 2016
Collaborator
Thanks for doing this! I'm short on time right now, so really appreciate people from the community fixing this.
There's one tricky area around deeply nested inline markup. I worked out an algorithm for it, but haven't had time to implement it yet. Probably people should coordinate before taking this on.
|
Thanks for doing this! I'm short on time right now, so really appreciate people from the community fixing this. There's one tricky area around deeply nested inline markup. I worked out an algorithm for it, but haven't had time to implement it yet. Probably people should coordinate before taking this on. |
azerupi commentedAug 5, 2016
This is an effort to update pulldown-cmark to the the latest spec (v0.26). It's not complete and I will probably not have the time and skill to finish this alone, so I thought I would post it so that it could be a collaborative effort.
The test case format in the spec has been modified from
to
So I changed
main.rsto correctly extract the new format. I wrote an iterator that returns the test cases from the spec and I think it turns out a little more readable than before.Failing tests
According to the official commonmark tool to test spec compliance, we pass
565/618tests. But according to the pulldown-cmark test we pass only504/618tests. I think this is due to the fact that html is not normalized before testing equality inpulldown-cmarkmaking it stricter than necessary.Some (a lot?) regressions are du to tab handling. In the new spec some tabs are converted to spaces but some aren't. If I am not mistaken, pulldown-cmark converts all tabs to 4 spaces?
If you want to help, just fix some test(s) and create a PR against this PR :)