Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
subprocess32 fails to compile on ancient RHEL/CentOS 5 & manylinux1 wheels - O_CLOEXEC and HAVE_PIPE2 related? #12
When i use pip or python install to install this extension:
The error messages:
Command "/usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-ekkMER-build/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-EebZzY-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-ekkMER-build/
changed the title from
subprocess32 unable to be installed via pip and python install
subprocess32 fails to compile on RHEL 5 and other ancient distros - O_CLOEXEC undeclared
Aug 8, 2016
added a commit
Aug 8, 2016
I successfully resolved the issue by uncomment the PIPE2 macro parts.
If necessary, code blocks related to O_CLOEXEC may also be removed.
The manylinux environment described in https://github.com/pypa/manylinux is extremely old, I believe it would result in a module with substandard correctness, not just performance.
RHEL 5 and CentOS 5 are long past their lifetime. I may consider pull requests, but I'm not going to spend time in such environments banging on things to get them to work.
Yes, thanks - current master does seem to compile on the manylinux docker image. I also tested automated wheel builds, built from https://github.com/MacPython/subprocess32-wheels - build and tests listed at https://travis-ci.org/MacPython/subprocess32-wheels, built wheels uploaded (automatically) to https://3f23b170c54c2533c070-1c8a9b3114517dc5fe17b7c3f8c63a43.ssl.cf2.rackcdn.com from whence they can be tested.
Any chance of a release with this fix?