Stop implementing deprecated BidirectionalIterator.
#714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kevmoo |
kevmoo
approved these changes
Dec 8, 2022
|
@kevmoo can you merge too? we don't have the needed permissions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TreeIteratorimplementedBidirectionalIterator, which is deprecated and will go away in Dart 3.0.This changes it to just implement
Iterarator, and have its ownmovePrevious.This could be a breaking change, but it does not appear that anyone ever casts the
TreeIteratortoBidirectionalIterator(because they might as well just keep theTreeIteratortype, and there is no helper function anywhere in the world which expects just aBidirectionalIteratorthat you can pass the iterator to).