New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long desc / episode name crash #387

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@seansd

seansd commented Oct 10, 2018

When a show desc or episdode name is longer than 32KB the import will fail due to reading old byte arrays and their lengths as shorts. Remove the byte arrays in favor of just using strings so the application doesn't crash.

Sean Snider
Updated, stick with current code style, removed old bytes properties …
…for episodeName and desc, which forces them to be strings and ensures that they can be larger than 32KB and hence app doesn't crash
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 10, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot commented Oct 10, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@seansd seansd changed the title from Updated, stick with current code style, removed old bytes properties … to Fix long desc / episode name crash Oct 10, 2018

@Narflex

This comment has been minimized.

Show comment
Hide comment
@Narflex

Narflex Oct 10, 2018

Member

I'll merge it once Travis builds it and gives the green light. You may need to change your GIT settings to use the email address you signed the Google CLA with...I'm not sure whether or not it'll let me merge your change otherwise. I did look it up internally based on your email and see you did sign...so I'll try to merge...but it may block me...we shall see. :)

Member

Narflex commented Oct 10, 2018

I'll merge it once Travis builds it and gives the green light. You may need to change your GIT settings to use the email address you signed the Google CLA with...I'm not sure whether or not it'll let me merge your change otherwise. I did look it up internally based on your email and see you did sign...so I'll try to merge...but it may block me...we shall see. :)

@Narflex Narflex merged commit 285ed82 into google:master Oct 10, 2018

1 of 2 checks passed

cla/google Need a CLA for one or more commit authors
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Narflex

This comment has been minimized.

Show comment
Hide comment
@Narflex

Narflex Oct 10, 2018

Member

Cool, it let me merge it.

Member

Narflex commented Oct 10, 2018

Cool, it let me merge it.

@seansd

This comment has been minimized.

Show comment
Hide comment
@seansd

seansd Oct 10, 2018

@Narflex do you have any idea when a new release version / installer would pick this up, i assume you have other stuff in the pipe for said release

seansd commented Oct 10, 2018

@Narflex do you have any idea when a new release version / installer would pick this up, i assume you have other stuff in the pipe for said release

@Narflex

This comment has been minimized.

Show comment
Hide comment
@Narflex

Narflex Oct 10, 2018

Member

I haven't built a new release in a long time...other people handle that now. :) I'm pretty sure the Windows ones are built manually...but the Linux ones I think are built automatically. For this fix, you just need to replace the Sage.jar file so you should be able to do that yourself pretty easily.

Member

Narflex commented Oct 10, 2018

I haven't built a new release in a long time...other people handle that now. :) I'm pretty sure the Windows ones are built manually...but the Linux ones I think are built automatically. For this fix, you just need to replace the Sage.jar file so you should be able to do that yourself pretty easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment