New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake support, implement fuzzers #284

Merged
merged 2 commits into from Jun 29, 2018

Conversation

Projects
None yet
3 participants
@alessandrogario
Contributor

alessandrogario commented Jun 20, 2018

The new CMake project allows the user to select which SDK version to use. The Xcode path is also configurable to support non-standard installation paths and/or systems with multiple versions installed.

Code signing can now be configured via command line, using the CODESIGN_IDENTITY environment variable.

New fuzzing targets (libFuzzer)

  • SantaCache
  • santactl
  • santad

New make targets:

  • tests: Runs the tests
  • fuzz: Runs the fuzzer
  • redist: Regenerates the redistributable folder
  • install: Installs Santa

A small issue has been found in santactl when the the sync-server returns a valid JSON that does not get deserialized to a dictionary object (not yet fixed inside this PR).

Add CMake support, implement fuzzers
The new CMake project allows the user to select which SDK version
to use. The Xcode path is also configurable to support non-standard
installation paths and/or systems with multiple versions installed.

Code signing can now be configured via command line, using the
CODESIGN_IDENTITY environment variable.

New fuzzing targets (libFuzzer)
 - SantaCache
 - santactl
 - santad

New make targets:
 - tests: Runs the tests
 - fuzz: Runs the fuzzer
 - redist: Regenerates the redistributable folder
 - install: Installs Santa
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jun 20, 2018

Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
Collaborator

googlebot commented Jun 20, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@alessandrogario

This comment has been minimized.

Show comment
Hide comment
@alessandrogario

alessandrogario Jun 20, 2018

Contributor

I have signed the CLA! 👍

Contributor

alessandrogario commented Jun 20, 2018

I have signed the CLA! 👍

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Jun 20, 2018

Collaborator

CLAs look good, thanks!

Collaborator

googlebot commented Jun 20, 2018

CLAs look good, thanks!

@russellhancox

Thank you for the PR, sorry it took so long to review. I had a few comments but they're mostly minor things.

Show outdated Hide outdated CMakeLists.txt
Show outdated Hide outdated CMakeLists.txt
Show outdated Hide outdated Conf/install.sh
Show outdated Hide outdated Conf/uninstall.sh
Show outdated Hide outdated Fuzzing/santactl/src/main.mm
Show outdated Hide outdated Fuzzing/santactl/CMakeLists.txt
Show outdated Hide outdated Fuzzing/santactl/src/main.mm
Show outdated Hide outdated Fuzzing/santactl/src/main.mm
Show outdated Hide outdated Fuzzing/santad/src/checkCacheForVnodeID.mm
@@ -0,0 +1,51 @@
#import "SNTDriverManager.h"

This comment has been minimized.

@russellhancox

russellhancox Jun 26, 2018

Collaborator

Can you add a comment at the top of this file describing what it's testing. I'm guessing it's a test that attempts to connect to the driver from multiple threads simultaneously doesn't cause crashes.

@russellhancox

russellhancox Jun 26, 2018

Collaborator

Can you add a comment at the top of this file describing what it's testing. I'm guessing it's a test that attempts to connect to the driver from multiple threads simultaneously doesn't cause crashes.

This comment has been minimized.

@alessandrogario

alessandrogario Jun 28, 2018

Contributor

You are right! I have added a comment at the top of the file

@alessandrogario

alessandrogario Jun 28, 2018

Contributor

You are right! I have added a comment at the top of the file

@alessandrogario

This comment has been minimized.

Show comment
Hide comment
@alessandrogario

alessandrogario Jun 28, 2018

Contributor

@russellhancox Thanks so much for the review! I've updated the branch with the changes you have requested

Contributor

alessandrogario commented Jun 28, 2018

@russellhancox Thanks so much for the review! I've updated the branch with the changes you have requested

@russellhancox russellhancox merged commit 629e702 into google:master Jun 29, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@russellhancox

This comment has been minimized.

Show comment
Hide comment
@russellhancox

russellhancox Jun 29, 2018

Collaborator

Thanks again for the submission!

Collaborator

russellhancox commented Jun 29, 2018

Thanks again for the submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment