Achieve better test coverage for Triples and Transform functions #73
Remove unrechable code from toClass.
We check for classes.size right after adding wellKnownTypes to that set. It will never be 0. The assertion in BuildClasses will never be true, since IsClass is the same condition as what causes this content to be added. Instead of bespoke exceptions, we use node's assertion to make sure that this won't happen. More philosophically, we should use this type of assertion whenever -- within the bounds of an exported function -- regardless of its inputs, a certain condition is impossible. Instead let's just make sure explicit exceptions are used for things that can go wrong in actuality.
- Loading branch information
ProTip! Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.