Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support muxed video+audio with URI-less EXT-X-MEDIA tag #1086

Closed
hung-yueh opened this issue Oct 25, 2017 · 7 comments
Closed

Support muxed video+audio with URI-less EXT-X-MEDIA tag #1086

hung-yueh opened this issue Oct 25, 2017 · 7 comments
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@hung-yueh
Copy link

Based on the HLS spec

The URI attribute of the EXT-X-MEDIA tag is REQUIRED if the media
type is SUBTITLES, but OPTIONAL if the media type is VIDEO or AUDIO.
If the media type is VIDEO or AUDIO, a missing URI attribute
indicates that the media data for this Rendition is included in the
Media Playlist of any EXT-X-STREAM-INF tag referencing this EXT-
X-MEDIA tag. If the media TYPE is AUDIO and the URI attribute is
missing, clients MUST assume that the audio data for this Rendition
is present in every video Rendition specified by the EXT-X-STREAM-INF
tag.

There is a missing logic in Shaka-player HLS parser which is the URI attribute should be optional if the media type is VIDEO or AUDIO. Current Shaka-player(version:2.2.4) sees them are all REQUIRED.

Please let me know if the above statements are true. If it's true, is there any plan to add this missing logic to the HLS parser? I might be able to help for creating PR for this. Thanks!

@joeyparrish joeyparrish added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format and removed needs triage labels Oct 26, 2017
@joeyparrish joeyparrish added this to the v2.4.0 milestone Oct 26, 2017
@joeyparrish
Copy link
Member

We were not aware of this issue, and we must have overlooked this in the spec. I've tentatively scheduled for v2.4.

To help us plan the work and understand the issue better, can you please provide sample content which is currently failing due to this issue? If you can't post a URL publicly, please email to shaka-player-issues@google.com instead.

Thanks!

@hung-yueh
Copy link
Author

Hi @joeyparrish ,

Thanks for responding the issue so quickly, I have sent the testing stream via email. Please let me know if there is anything I can help.

@joeyparrish
Copy link
Member

Ah, I see now. So without the URI attribute in the EXT-X-MEDIA audio tag, the audio is muxed in with the video. Is that correct?

@joeyparrish joeyparrish changed the title [HLS] Support Alternative Renditions Question [HLS] Support muxed video+audio with URI-less EXT-X-MEDIA tag Oct 27, 2017
@joeyparrish joeyparrish changed the title [HLS] Support muxed video+audio with URI-less EXT-X-MEDIA tag Support muxed video+audio with URI-less EXT-X-MEDIA tag Oct 27, 2017
@hung-yueh
Copy link
Author

@joeyparrish Yes, you are totally correct!

@joeyparrish joeyparrish modified the milestones: v2.4.0, Backlog Dec 4, 2017
@sagb
Copy link

sagb commented Jan 16, 2019

We have the same problem. Flussonic (major video streaming software) generates playlists with audio tracks URI, except of the default:

#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="aac",NAME="a1",DEFAULT=YES,AUTOSELECT=YES
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="aac",NAME="a2",DEFAULT=NO,AUTOSELECT=YES,URI=....
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="aac",NAME="a3",DEFAULT=NO,AUTOSELECT=YES,URI=....

It would be nice if shaka could handle this.

@joeyparrish joeyparrish modified the milestones: Backlog, v2.5 Jan 18, 2019
@joeyparrish
Copy link
Member

The commit message in adde0bd is malformed, but this issue was fixed by that commit.

joeyparrish pushed a commit that referenced this issue Jan 19, 2019
If an X-EXT-MEDIA asset does not contain URI, ignore when building stream list.
URI attribute should only be required on subtitles, according to the spec.

Fixes #1086
Fixes #1730

Backported to v2.4.x
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.4.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 19, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants