Issue with getTextLanguagesAndRoles and getAudioLanguagesAndRoles in DemoApp #1258
Assignees
Labels
flag: Why didn't we catch this sooner
This issue is embarassing; we may still need an automated test that could have prevented this issue
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
|
@avelad Thank you for finding this. I have been able to repo this and have a fix ready for review. I hope to have this closed by end of day. |
TheModMaker
added
the
flag: Why didn't we catch this sooner
shaka-bot
pushed a commit
that referenced
this issue
Jan 29, 2018
Added a test to check that the language and role fields are preserved in the compiled build. Issue #1258 Change-Id: Id655549694ee0c68e213ed3bed5fb08f10279234
|
Fix cherry-picked for v2.3.2 |
joeyparrish
pushed a commit
that referenced
this issue
Jan 30, 2018
Added a test to check that the language and role fields are preserved in the compiled build. Issue #1258 Change-Id: Id655549694ee0c68e213ed3bed5fb08f10279234
joeyparrish
pushed a commit
that referenced
this issue
Jan 30, 2018
Since we pass the pairing of language and role up to the app, this change adds an extern to ensure that keys don't get renamed. Closes #1258 Change-Id: I3a18951bde4ded6a8d29b21c1e903a7f4e70b849
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
NOTE: For bugs, if you delete this template, we will send it again and ask you to fill it out.
Have you read the FAQ and checked for duplicate open issues?: Yes
What version of Shaka Player are you using?: 2.3.1
Can you reproduce the issue with our latest release version?: Yes
Can you reproduce the issue with the latest code from
master?: YesAre you using the demo app or your own custom app?: Demo app
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?: Chrome 64 / Ubuntu 17.04
What did you do?
Load demo page in uncompiled mode and compiled mode
What did you expect to happen?
Track selector is not working (audio and text)
What actually happened?
Uncompiled mode
Compile mode
Note: I think that the problem is getTextLanguagesAndRoles and getAudioLanguagesAndRoles, the spec saids that returns (non-null) {Array.<{language: string, role: string}>} and I see:
[{"language":"en","vb":"main"},{"language":"fr","vb":""},{"language":"de","vb":""},{"language":"it","vb":""},{"language":"es","vb":""}] and [{"language":"el","vb":""},{"language":"en","vb":"main"},{"language":"fr","vb":""},{"language":"pt-br","vb":""}]
The text was updated successfully, but these errors were encountered: