Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbortableOperation failing on IE11 due to Promise polyfill #1260

Closed
joeyparrish opened this issue Jan 30, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@joeyparrish
Copy link
Member

commented Jan 30, 2018

AbortableOperation tests (and tests for all networking components, which now use AbortableOperation) are failing on IE11. This has been tracked to a bug in our Promise polyfill. This only affects the nightly build and has not affected any release versions.

@joeyparrish joeyparrish added the bug label Jan 30, 2018

@joeyparrish joeyparrish added this to the v2.4.0 milestone Jan 30, 2018

@joeyparrish joeyparrish self-assigned this Jan 30, 2018

shaka-bot pushed a commit that referenced this issue Jan 30, 2018

Improve AbortableOperation tests
This does not solve failures on IE11, but does make them clearer and
helps pinpoint the root cause.

Issue #1260

Change-Id: I00a10b38d1eb1f3293c3285a34bde96c631d1c74
@joeyparrish

This comment has been minimized.

Copy link
Member Author

commented Jan 30, 2018

It looks like the easiest answer is to stop using our own polyfill for Promises. Switching to https://github.com/lahmatiy/es6-promise-polyfill fixes the bug. That polyfill is also smaller than ours (1kB vs 4kB), and it allows individual applications to decide if they want to support IE11 by loading that polyfill in addition to Shaka Player.

So starting in v2.4.0, IE support will be contingent on loading this additional polyfill, which our demo app and tests will do.

@shaka-bot shaka-bot closed this in 8235748 Jan 30, 2018

@shaka-bot shaka-bot added the archived label Apr 2, 2018

@google google locked and limited conversation to collaborators Apr 2, 2018

@joeyparrish

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

This change will be out in v2.4 this week. Apps using v2.4+ will need to polyfill Promise support in IE at the application level. We recommend this polyfill: https://github.com/lahmatiy/es6-promise-polyfill

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.