Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog dates #1263

Closed
nocarryr opened this issue Jan 31, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@nocarryr
Copy link
Contributor

commented Jan 31, 2018

The two most recent additions to CHANGELOG.md seem to have the wrong year:
2.3.1 and 2.2.10

Seems a bit "nit-picky", but could be a point of confusion.

@vaage vaage self-assigned this Jan 31, 2018

@vaage

This comment has been minimized.

Copy link
Member

commented Jan 31, 2018

@nocarryr Thanks for finding that. We appreciate the attention to detail.

@vaage vaage added the bug label Jan 31, 2018

@vaage vaage closed this in c0a1c39 Jan 31, 2018

@nocarryr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2018

👍

@vaage Thanks for helping to make shaka-player such a great product!

@joeyparrish

This comment has been minimized.

Copy link
Member

commented Jan 31, 2018

Thanks! I have updated the corresponding text on the github releases page: https://github.com/google/shaka-player/releases/tag/v2.2.10 https://github.com/google/shaka-player/releases/tag/v2.3.1

@joeyparrish

This comment has been minimized.

Copy link
Member

commented Feb 1, 2018

Cherry-picked to v2.3.2

joeyparrish added a commit that referenced this issue Feb 1, 2018

Fix Wrong Year in CHANGELOG
Fix Wrong Year in CHANGELOG

It looks like 2017 was such a great year for Shaka Player
that we did not want it to end, so in our CHANGELOG we
decided to start 2017 all over again.

This change updated the two entries to say 2018 instead of
2017.

Backported to v2.3.x

Closes #1263

@shaka-bot shaka-bot added the archived label Apr 2, 2018

@google google locked and limited conversation to collaborators Apr 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.