Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDATA in DASH Location tag #1508

Closed
tmagnien opened this issue Jul 27, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@tmagnien
Copy link

commented Jul 27, 2018

Hi. We're using DASH Location tag to load-balance our streams on different servers.

However, our URL has a query string and & characters should be quoted to &. I tried enclosing it in a CDATA block but it does not seem to work. Is this normal ? (Using & works but it would be easier for me not to rewrite the URL).

Thanks,
Thierry

@TheModMaker

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

You need to double escape it. & For example:

<Location>http://example.com/?q=foo&amp;amp;bar</Location>

Once we parse this, it will be sent to the server as http://example.com/?q=foo&amp;bar.

@vaage

This comment has been minimized.

Copy link
Member

commented Jul 27, 2018

@tmagnien does @TheModMaker instructions fix your problem?

@tmagnien

This comment has been minimized.

Copy link
Author

commented Jul 28, 2018

Hi. Sorry, I realize my question was not clear.

To sum up, this works:
<Location>http://somedomain/url?foo=1&amp;bar=2</Location>

But this is ignored:
<Location><![CDATA[http://somedomain/url?foo=1&bar=2]]></Location>

And I wanted to know if this is expected behaviour, as the 2nd form using CDATA is easier for me to generate.

Thanks,
Thierry

@TheModMaker

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

I don't really see a reason this shouldn't be supported. It should be a simple fix. I'll add it to our next release.

@TheModMaker TheModMaker added bug and removed needs triage labels Jul 30, 2018

@TheModMaker TheModMaker added this to the v2.5 milestone Jul 30, 2018

@TheModMaker TheModMaker self-assigned this Jul 30, 2018

@shaka-bot shaka-bot closed this in bc4de8c Jul 30, 2018

joeyparrish added a commit that referenced this issue Aug 6, 2018

Allow CDATA in text nodes.
Fixes #1508

Change-Id: I04817c8077b298b56ea11cb8cb8d1a6e832ce4ee

@shaka-bot shaka-bot added the archived label Sep 28, 2018

@google google locked and limited conversation to collaborators Sep 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.