Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
There should not be a gap in text references >1s error #1562
Have you read the FAQ and checked for duplicate open issues?:
What did you do?
This content was produced with shaka-packager. Please note that this content even with subtitles enabled is playable with dashjs and on android with exoplayer. Is this an issue with the packaged content or with shaka player?
I managed to reproduce using the latest code in
Full repro steps I came up with:
Also reproduces in v2.4.4, v2.3.10, but not in v2.2.10.
When the assertion is triggered, the value of
This offset value seems to come from this part of the manifest:
<Representation id="0" bandwidth="1148" codecs="wvtt" mimeType="application/mp4"> <SegmentTemplate timescale="1000" presentationTimeOffset="57486242" initialization="--redacted--.mp4" media="--redacted--_$Number$.m4s" startNumber="1"> <SegmentTimeline> <S t="57481600" d="3200" r="768"/> </SegmentTimeline>
According to the manifest, it was generated by Shaka Packager version
The only difference in my fork was actually suggested by @kqyang himself and should not cause any of this I believe. The change is only about reading the subtitle file indefinitely while packaging live content. As this is VOD, it should not be affected at all.