Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: A11y: Live stream timecode is not accessible as button #1861

Closed
joeyparrish opened this issue Apr 3, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@joeyparrish
Copy link
Member

commented Apr 3, 2019

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master

Can you reproduce the issue with our latest release version?
N/A - no UI in v2.4.x

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
demo

What browser and OS are you using?
ChromeOS

What are the manifest and license server URIs?
Any live stream

What did you do?

  1. Load live stream
  2. Try to tab to the timecode

What did you expect to happen?
Since this is clickable (seeks to live edge), it should be tab-seekable and accessible as well.

What actually happened?
The timecode can't be tab-navigated, and it has no role and no aria label. It is a div with a click event.

This should be accessible, ideally as a styled button (inherently accessible) instead of a div. The aria label ARIA_LABEL_LIVE (already exists, unused) should be applied if player.isLive() to alert users that it can be used to seek to the live edge. The same label could be used as a tooltip for sighted users, again if player.isLive().

@joeyparrish joeyparrish added bug UI labels Apr 3, 2019

@shaka-bot shaka-bot added this to the v2.5 milestone Apr 3, 2019

shaka-bot pushed a commit that referenced this issue Apr 3, 2019

Add TODO for a11y of timecode
Issue #1861

Change-Id: I9bf7dc65883f9aa9b6853999a2c23a720919de26

@michellezhuogg michellezhuogg self-assigned this Apr 5, 2019

@shaka-bot shaka-bot closed this in 8459362 Apr 9, 2019

@shaka-bot shaka-bot added the archived label Jun 8, 2019

@google google locked and limited conversation to collaborators Jun 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.