Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing variants in HLS Angel One #1908

Closed
joeyparrish opened this issue May 1, 2019 · 1 comment
Closed

Missing variants in HLS Angel One #1908

joeyparrish opened this issue May 1, 2019 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master

Can you reproduce the issue with our latest release version?
Yes
I can also reproduce the issue back to v2.2.1, but not in v2.2.0.

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo

What browser and OS are you using?
Linux Chrome

What are the manifest and license server URIs?
"Angel One HLS" in demo app
https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8

What did you do?

  1. Open the demo with Angel One HLS.
  2. Look at the variant track list (info panel for old versions, player UI in v2.5.0-beta3 and up)

What did you expect to happen?
All resolutions (5) should be shown for all languages.

What actually happened?
Only Spanish seems to list all resolutions. Each other language seems to have only one resolution. Variants were not generated (or were filtered out somehow) for the other languages.

This can be reproduced in v2.2.1, but not v2.2.0:

https://v2-2-0-dot-shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;play

https://v2-2-1-dot-shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;play

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 1, 2019
@joeyparrish joeyparrish added this to the v2.5 milestone May 1, 2019
@joeyparrish
Copy link
Member Author

Bug introduced in 30d32b1 ("Add support for MP4+TTML in HLS"), August 2017, and first shipped in v2.2.1.

@joeyparrish joeyparrish self-assigned this May 1, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Jul 1, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants