Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading logging in DrmEngine#fillInDrmInfoDefaults_ #1288

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
4 participants
@chrisfillmore
Copy link
Contributor

commented Feb 9, 2018

Closes #1284

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2018

Test Failure:

Chrome 64.0.3282 (Linux 0.0.0)
  DrmEngine init fails if license server is not configured FAILED
    Expected spy shaka.log.error to have been called.
        at test/media/drm_engine_unit.js:505:29
        at <anonymous>

Failed 1 tests, passed 1321, skipped 45
@joeyparrish

This comment has been minimized.

Copy link
Member

commented Feb 9, 2018

Could you update that test as well? Thanks!

@joeyparrish joeyparrish added this to the v2.4.0 milestone Feb 9, 2018

@joeyparrish joeyparrish self-assigned this Feb 9, 2018

@chrisfillmore

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2018

Sorry for missing that!

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2018

All tests passed!

@joeyparrish joeyparrish merged commit 792775c into google:master Feb 20, 2018

2 checks passed

cla/google All necessary CLAs are signed
shaka-build-bot All tests passed
@joeyparrish

This comment has been minimized.

Copy link
Member

commented Feb 20, 2018

Merged. Thanks!

@joeyparrish

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

Cherry-picked for v2.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.