Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1317 - Warn if we don't get a valid date from UTCTiming server. #1318

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
3 participants
@TheJohnBowers
Copy link
Contributor

commented Feb 24, 2018

Warn if parsing the date from the UTC timing element fails, instead of silently failing to do time synchronization.

Warn if parsing the date from the UTC timing element fails, instead
of silently failing to do time synchronization.
@joeyparrish
Copy link
Member

left a comment

Looks good, thanks!

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2018

All tests passed!

@joeyparrish joeyparrish merged commit b0f7ba4 into google:master Feb 26, 2018

2 checks passed

cla/google All necessary CLAs are signed
shaka-build-bot All tests passed

joeyparrish added a commit that referenced this pull request Mar 1, 2018

@joeyparrish joeyparrish added enhancement and removed needs triage labels Mar 1, 2018

@joeyparrish joeyparrish added this to the v2.4.0 milestone Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.