Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set server certificate before Store and Delete #1639

Merged
merged 2 commits into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@gigon
Copy link
Contributor

commented Oct 21, 2018

Library: Call setServerCertificate before store and delete operations, when serverCertificate exists:
In case of store(), it can be configured by the application.
In case of delete(), it is retrieved from the stored manifest.

Demo application: before store(), request and configure the certificate, when a certificateUri is given in asset.

Fixes #1623.

Set server certificate before Store and Delete
Call setServerCertificate before store and
delete operations, when serverCertificate
exists.
In demo application, request and
configure certificate when certificateUri
is given in asset.

Fixes #1623.
Show resolved Hide resolved demo/offline_section.js Outdated
Show resolved Hide resolved lib/media/drm_engine.js Outdated
Show resolved Hide resolved lib/media/drm_engine.js Outdated
Show resolved Hide resolved lib/offline/storage.js Outdated
Show resolved Hide resolved lib/offline/session_deleter.js Outdated
Show resolved Hide resolved lib/media/drm_engine.js Outdated
@gigon

This comment has been minimized.

Copy link
Contributor Author

commented Oct 23, 2018

Thanks @TheModMaker , I resolved the issues.

@gigon gigon force-pushed the gigon:bugfix/offline_1623 branch from 237c763 to 0e4cd55 Oct 23, 2018

@TheModMaker
Copy link
Member

left a comment

Looks good to me, I'll run this through our build bot.

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 24, 2018

All tests passed!

@TheModMaker TheModMaker merged commit 5177309 into google:master Oct 24, 2018

2 checks passed

cla/google All necessary CLAs are signed
shaka-build-bot All tests passed

@gigon gigon deleted the gigon:bugfix/offline_1623 branch Oct 25, 2018

@joeyparrish

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

Released in v2.5.0-beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.