Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make manifest redirections sticky for updates #1880

Merged
merged 3 commits into from Apr 15, 2019
Merged

Make manifest redirections sticky for updates #1880

merged 3 commits into from Apr 15, 2019

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 12, 2019

Resolves #1367

joeyparrish
joeyparrish requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test? Thanks!

lib/dash/dash_parser.js Outdated Show resolved Hide resolved
@avelad
Copy link
Collaborator Author

avelad commented Apr 15, 2019

@joeyparrish, I have seen that there was a test that covered the functionality, so I have updated it to meet the new requirements.

joeyparrish
joeyparrish approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@shaka-bot
Copy link
Collaborator

Test Failure:

*** A required dependency is missing: npm
Build step 'Execute shell' marked build as failure

@joeyparrish
Copy link
Member

Something seems to be wrong with our build bot. I will investigate.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 65e9957 into shaka-project:master Apr 15, 2019
@joeyparrish
Copy link
Member

Thank you!

@avelad avelad deleted the sticky-manifest branch March 16, 2022 16:00
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP redirects should be "sticky" for manifest updates
3 participants
@avelad @shaka-bot @joeyparrish