Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ttml background image support #2034

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@valotvince
Copy link
Contributor

commented Jul 15, 2019

Since #1962, any nodes with begin or end attributes with empty content would not be interpreted as cues (<p begin="xx" end="xxx" smpte:backgroundImage="yyy" /> for example)

This PR fixes this.

To test: Live sim TTML Image Subtitles embedded (VoD)

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

All tests passed!

)
!cueElement.hasAttribute('end');

if (

This comment has been minimized.

Copy link
@ismena

ismena Jul 15, 2019

Member

Please add a more detailed comment on this case. Why are we letting through the elements with time stamps? Why are we ignoring the ones without?

This comment has been minimized.

Copy link
@valotvince

valotvince Jul 16, 2019

Author Contributor

Sure thing :)

@@ -674,6 +674,49 @@ describe('TtmlTextParser', () => {
{periodStart: 0, segmentStart: 0, segmentEnd: 0});
});

it('should let empty paragraphs with begin or end attributes through', () => {

This comment has been minimized.

Copy link
@ismena

ismena Jul 15, 2019

Member

Thanks for the tests!

@ismena

ismena approved these changes Jul 16, 2019

@shaka-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

All tests passed!

@ismena ismena merged commit a88e3be into google:master Jul 16, 2019

2 checks passed

cla/google All necessary CLAs are signed
shaka-build-bot All tests passed
@ismena

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

There we go. I also tested all of our subtitles assets, which seem to be fine :)

AnteWall added a commit to AnteWall/shaka-player that referenced this pull request Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.