Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ttml background image support #2034

Merged
merged 2 commits into from Jul 16, 2019
Merged

Conversation

@valotvince
Copy link
Contributor

@valotvince valotvince commented Jul 15, 2019

Since #1962, any nodes with begin or end attributes with empty content would not be interpreted as cues (<p begin="xx" end="xxx" smpte:backgroundImage="yyy" /> for example)

This PR fixes this.

To test: Live sim TTML Image Subtitles embedded (VoD)

@shaka-bot
Copy link
Collaborator

@shaka-bot shaka-bot commented Jul 15, 2019

All tests passed!

Loading

)
!cueElement.hasAttribute('end');

if (
Copy link
Member

@ismena ismena Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a more detailed comment on this case. Why are we letting through the elements with time stamps? Why are we ignoring the ones without?

Loading

Copy link
Contributor Author

@valotvince valotvince Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing :)

Loading

@@ -674,6 +674,49 @@ describe('TtmlTextParser', () => {
{periodStart: 0, segmentStart: 0, segmentEnd: 0});
});

it('should let empty paragraphs with begin or end attributes through', () => {
Copy link
Member

@ismena ismena Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

Loading

ismena
ismena approved these changes Jul 16, 2019
@shaka-bot
Copy link
Collaborator

@shaka-bot shaka-bot commented Jul 16, 2019

All tests passed!

Loading

@ismena ismena merged commit a88e3be into google:master Jul 16, 2019
2 checks passed
Loading
@ismena
Copy link
Member

@ismena ismena commented Jul 16, 2019

There we go. I also tested all of our subtitles assets, which seem to be fine :)

Loading

AnteWall added a commit to AnteWall/shaka-player that referenced this issue Jul 17, 2019
TheModMaker added a commit that referenced this issue Aug 27, 2019
Change-Id: I2c51a6e52a01cad0e288bccde7f9ca27008aaa94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants