Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improvements for Faraday usage #2

merged 1 commit into from May 24, 2012


None yet
2 participants

sqrrrl commented May 17, 2012

No longer recreate Faraday::Requests in clients when adding credentials. Also no longer forces the body to be string unless necessary for signing (e.g. OAuth 1.0 form post) to allow use of Faraday middleware that allows non-string bodies and streaming of large uploads.

Optimize processing when passing in Faraday::Request objects in the
clients to avoid recreating. Don't force body to be string when
adding the credentials unless necessary (e.g. OAuth 1.0 form post)
to allow use of Faraday middleware and/or streaming of large uploads.

sporkmonger added a commit that referenced this pull request May 24, 2012

Merge pull request #2 from sqrrrl/master
Improvements for Faraday usage

@sporkmonger sporkmonger merged commit 26a7847 into google:master May 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment