Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WP 4.9 #47

Closed
Mte90 opened this issue Jun 24, 2019 · 6 comments

Comments

Projects
None yet
6 participants
@Mte90
Copy link

commented Jun 24, 2019

Describe the bug
Readme say that is compatible with WP 4.7 but doesn't seems.
immagine

I think that is looking for JS stuff that are available only after 5.0


Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

@felixarntz

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Hi @Mte90, thanks for the report!
The plugin bundles those dependencies itself specifically to load them in these cases (pre-5.0), so they should be available then. We're gonna check what's wrong there.

Can you provide us with a bit more information? You're using WP 4.9? Do you have the Gutenberg plugin installed by any chance?

@Mte90

This comment has been minimized.

Copy link
Author

commented Jun 24, 2019

WordPress 4.9 without gutenberg plugin and amp plugin installed.

@ivankristianto

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

This issue is related to AMP plugin (version 1.2.0),
and it fixed in this PR:
This issue is related to amp-wp plugin, and it fixed in this PR:
ampproject/amp-wp#2688

I think it will fix in AMP plugin next release.

@swissspidy

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@Mte90 Since you've already tested the version of the AMP plugin with the bugfix, can you confirm that Site Kit is now working properly as well?

@Mte90

This comment has been minimized.

Copy link
Author

commented Jul 1, 2019

I can confirm that now with the latest amp is working.

@jamesozzie

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

@Mte90 Good news, thanks for the update. If you have a minute leave a review for the plugin authors with their rapid fix.

@jamesozzie jamesozzie closed this Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.