Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build instructions for Go 1.18+ #412

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fix build instructions for Go 1.18+ #412

merged 1 commit into from
Aug 15, 2022

Conversation

ankitpati
Copy link
Contributor

Reference: https://golang.org/doc/go-get-install-deprecation

I’m unable to run the REPL by following the build instructions in the README.md, but using go install instead of go get works for me:

$ podman run --pull always -it --rm docker.io/library/golang:latest
root@445c025009b7:/go# go version
go version go1.18.4 linux/amd64
root@445c025009b7:/go# starlark
bash: starlark: command not found
root@445c025009b7:/go# go get -u go.starlark.net/cmd/starlark
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
root@445c025009b7:/go# go install go.starlark.net/cmd/starlark@latest
go: downloading go.starlark.net v0.0.0-20220714194419-4cadf0a12139
go: downloading github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e
go: downloading golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f
root@445c025009b7:/go# starlark
Welcome to Starlark (go.starlark.net)
>>> ^D

Copy link
Collaborator

@adonovan adonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adonovan adonovan merged commit e1b9ebd into google:master Aug 15, 2022
@ankitpati
Copy link
Contributor Author

Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants