Skip to content
Permalink
Browse files

pkg/report: fix error in report symbolization

  • Loading branch information...
R3x authored and dvyukov committed Jun 26, 2019
1 parent 9b3b970 commit 4d3422405ed6c68b57f24f80dcfd0abd3a2c6c1a
Showing with 8 additions and 8 deletions.
  1. +1 −1 pkg/report/netbsd.go
  2. +7 −7 pkg/report/netbsd_test.go
@@ -27,7 +27,7 @@ type netbsd struct {
var (
netbsdSymbolizeRe = []*regexp.Regexp{
// stack
regexp.MustCompile(` at ([A-Za-z0-9_]+)\+0x([0-9a-f]+)`),
regexp.MustCompile(` at netbsd:([A-Za-z0-9_]+)\+0x([0-9a-f]+)`),
// witness
regexp.MustCompile(`#[0-9]+ +([A-Za-z0-9_]+)\+0x([0-9a-f]+)`),
}
@@ -17,19 +17,19 @@ func TestNetbsdSymbolizeLine(t *testing.T) {
}{
// Normal symbolization.
{
"closef(ffffffff,ffffffff) at closef+0xaf\n",
"closef(ffffffff,ffffffff) at closef+0xaf kern_descrip.c:1241\n",
"closef(ffffffff,ffffffff) at netbsd:closef+0xaf\n",
"closef(ffffffff,ffffffff) at netbsd:closef+0xaf kern_descrip.c:1241\n",
},
// Inlined frames.
{
"sleep_finish_all(ffffffff,32) at sleep_finish_all+0x22\n",
"sleep_finish_all(ffffffff,32) at sleep_finish_all+0x22 sleep_finish_timeout kern_synch.c:336 [inline]\n" +
"sleep_finish_all(ffffffff,32) at sleep_finish_all+0x22 kern_synch.c:157\n",
"sleep_finish_all(ffffffff,32) at netbsd:sleep_finish_all+0x22\n",
"sleep_finish_all(ffffffff,32) at netbsd:sleep_finish_all+0x22 sleep_finish_timeout kern_synch.c:336 [inline]\n" +
"sleep_finish_all(ffffffff,32) at netbsd:sleep_finish_all+0x22 kern_synch.c:157\n",
},
// Missing symbol.
{
"foo(ffffffff,ffffffff) at foo+0x1e",
"foo(ffffffff,ffffffff) at foo+0x1e",
"foo(ffffffff,ffffffff) at netbsd:foo+0x1e",
"foo(ffffffff,ffffffff) at netbsd:foo+0x1e",
},
// Witness symbolization.
{

0 comments on commit 4d34224

Please sign in to comment.
You can’t perform that action at this time.