From 6a8d39b1f4f7520206b8c0647d1852e70485c228 Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Tue, 7 Jan 2020 16:00:25 +0100 Subject: [PATCH] syz-manager: disable corpus rotation Temporary disable corpus rotation b/c we suspect it negatively affects fuzzing. But we don't have hard data, and the easiest way to check is to disable and see what happens. Update #1348 --- syz-manager/rpc.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/syz-manager/rpc.go b/syz-manager/rpc.go index f4fd47211e14..e9df2976a16d 100644 --- a/syz-manager/rpc.go +++ b/syz-manager/rpc.go @@ -99,7 +99,8 @@ func (serv *RPCServer) Connect(a *rpctype.ConnectArgs, r *rpctype.ConnectRes) er r.EnabledCalls = serv.enabledSyscalls r.GitRevision = sys.GitRevision r.TargetRevision = serv.target.Revision - if serv.mgr.rotateCorpus() && serv.rnd.Intn(3) != 0 { + // TODO: temporary disabled b/c we suspect this negatively affects fuzzing. + if false && serv.mgr.rotateCorpus() && serv.rnd.Intn(3) != 0 { // We do rotation every other time because there are no objective // proofs regarding its efficiency either way. // Also, rotation gives significantly skewed syscall selection