Skip to content
Permalink
Tree: 55684ce16b
Commits on Mar 25, 2019
  1. pkg/html: update generated file

    dvyukov committed Mar 25, 2019
  2. dashboard/app: properly handle build failures

    dvyukov committed Mar 22, 2019
    Separate kernel and syzkaller build failures.
    Fix logic to understand when a build is fixed:
    look if kernel/syzkaller commit changes to understand
    if it's a new good build or re-upload of an old build.
    
    Fixes #1014
Commits on Mar 24, 2019
  1. pkg/report: skip memmove on linux

    dvyukov committed Mar 24, 2019
  2. dashboard/app: fix infinite emails

    dvyukov committed Mar 24, 2019
    We override crash with the crash used for bisection
    to make the information more consistent.
    However if bisection crash only have syz repro
    and there is now another crash with C repro,
    then we always think that we have not reported C repro
    and continue sending the same report again and again.
    Don't override the crash with bisection crash in such case.
  3. sys/linux: move openat to dev_rtc.txt

    shankarapailoor authored and dvyukov committed Mar 23, 2019
    move openat$rtc to rtc_dev and change return type to fd_rtc
Commits on Mar 23, 2019
  1. tools/syz-execprog: remove dead code

    mudongliang authored and dvyukov committed Mar 22, 2019
Commits on Mar 22, 2019
  1. dashboard/app: import datastore as db

    dvyukov committed Mar 22, 2019
    datastore is too long name for such widely used packages.
    Import it as db throughout. Nicely reduces line lengths.
  2. dashboard/app: mark managers as bad after 6 hours of inactivity

    dvyukov committed Mar 22, 2019
    It should not take more than 6 hours to rebuild all kernels.
    So it's better to highlight bad managers earlier.
  3. pkg/bisect: detect when too many instances errored

    dvyukov committed Mar 22, 2019
    We currently skip a commit iff all 10 instances errored.
    But if, say, only 9 errored we consider it as OK,
    but this significnalty reduces chances of detecting flaky crashes.
    So skip if more than 2/3 errored.
    
    Update #501
  4. dashboard/app: slightly relax command parsing

    dvyukov committed Mar 22, 2019
    Users have misspelled test: multiple times.
    Accept commands without the colon.
  5. syz-ci: fix filling of kernel commit in bisection jobs

    dvyukov committed Mar 22, 2019
    There is a bit of a mess: dashboard expects the start commit
    in build info, but syz-ci sends the resulting cause commit.
    Moreover for inconclusive bisection the commit is not filled at all.
    Fill start commit in build info on start.
    
    Update #501
  6. dashboard/app: add uncc command

    dvyukov committed Mar 21, 2019
    Add "#syz uncc" command as a safety handle.
    The command allows sender to unsubscribe from all future communication on the bug.
    
    Linus mentioned possibility of saying "I'm not the right person for this report"
    in the context of bug reminders:
    https://groups.google.com/d/msg/syzkaller/zYlQ-b-QPHQ/AJzpeObcBAAJ
  7. dashboard/app: add bisection link to emails

    dvyukov committed Mar 21, 2019
    Add link to more information about bisection process
    to emails that contain bisection results.
    This seems to be a hot topic for questions.
    
    Update #501
Commits on Mar 21, 2019
  1. docs: add custom anchors to headers (2)

    dvyukov committed Mar 21, 2019
    Div's seem to work. Use them.
  2. docs: add custom anchors to headers (2)

    dvyukov committed Mar 21, 2019
    The previous attempt made things only worse... Try 2.
  3. docs: add custom anchors to headers

    dvyukov committed Mar 21, 2019
    Add shorter anchors that does not depend on actual text (subject to change).
    This allows to generate shorter stable links to docs.
    Let's see if this syntax works.
  4. pkg/build: add a test for build failure root causing

    dvyukov committed Mar 21, 2019
    Such error popped up during bisection on older kernels.
    It's already detected properly, yet build failed with just "make failed"...
    Unclear why that happened, but the test won't harm.
    
    Update #501
  5. pkg/csource: allow to ignore warnings during build

    dvyukov committed Mar 21, 2019
    Running bisection using an older repro failed with:
    
        <stdin>: In function ‘syz_mount_image.constprop’:
        <stdin>:298:3: error: argument 1 null where non-null expected [-Werror=nonnull]
        In file included from <stdin>:26:0:
        /usr/include/x86_64-linux-gnu/sys/stat.h:320:12: note: in a call to function ‘mkdir’ declared here
         extern int mkdir (const char *__path, __mode_t __mode)
    
    Let's be safe and ignore warnings during repro/bisect.
    Everything that runs during tests still has all warnings.
    
    Update #501
  6. executor: prevent non-null expected warnings

    dvyukov committed Mar 21, 2019
    The added test triggers warnings like these:
    
    <stdin>: In function ‘syz_mount_image.constprop’:
    <stdin>:298:3: error: argument 1 null where non-null expected [-Werror=nonnull]
    In file included from <stdin>:26:0:
    /usr/include/x86_64-linux-gnu/sys/stat.h:320:12: note: in a call to function ‘mkdir’ declared here
     extern int mkdir (const char *__path, __mode_t __mode)
                ^~~~~
    cc1: all warnings being treated as errors
    
    <stdin>: In function ‘syz_open_procfs.constprop’:
    <stdin>:530:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    <stdin>:532:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    <stdin>:534:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    
    Use volatile for all arguments of syz_ functions to prevent
    compiler from treating the arguments as constants in reproducers.
    
    Popped up during bisection that used a repro that previously worked.
    Update #501
  7. Makefile: fix tidy rule

    dvyukov committed Mar 21, 2019
    Building executor now requires GOOS/GOARCH macros.
  8. dashboard/app: use 12-char hash in Fixes tags

    dvyukov committed Mar 21, 2019
    @ebiggers pointed out that Fixes tags should use 12-char hash:
    https://groups.google.com/d/msg/syzkaller-bugs/yUhRrLD6T6A/3TMwOWvWAgAJ
    I can't find any documentation on this, but it looks like most
    existing tags follow this convention so use 12-char hashes.
  9. pkg/vcs: fix fuchsia's git repo directory.

    mvanotti authored and dvyukov committed Mar 20, 2019
    This commit changes the fuchsia git repo to make it point to the main
    repo instead of just "zircon".
    
    Previously, zircon had its own git repo, so syzkaller had a wrapper that
    would issue jiri commands for the whole fuchsia repo, but would just
    report commits in the zircon repo.
    
    Recently, fuchsia merged most of its repositories in just one big git
    repo. So now, zircon is part of the fuchsia git repo. I think the code
    continued working because the old zircon repo is still part of a git
    repository, so git commands worked there.
    
    The new code now doesn't have any special casing for Zircon, and now
    (almost) everything is part of the fuchsia repo. The other repos are now
    git submodules.
Commits on Mar 20, 2019
  1. pkg/report: deduplicate sctp "no chunks on the queues" reports

    markjdb authored and dvyukov committed Mar 20, 2019
  2. syz-ci: fix a typo

    dvyukov committed Mar 20, 2019
  3. pkg/vcs: fix git tag --points-at invocation

    dvyukov committed Mar 20, 2019
    Turns out older versions of git don't imply --list for --points-at and fail.
    So add --list explicitly.
    
    Update #501
  4. syz-ci: improve job loop logic

    dvyukov committed Mar 20, 2019
    1. Prevent grabbing the next job on stop with 50% probability.
    2. Don't claim jobs if another build is already in progress.
    
    Update #501
  5. dashboard/app: request test/bisect jobs separately

    dvyukov committed Mar 20, 2019
    Allow separate sets of managers for patch testing and for bisection.
    This makes things more flexible on syz-ci deployment side.
    Remove previous hacks for bisection deployment.
    
    Update #501
  6. pkg/bisect: use CheckoutCommit instead of SwitchCommit

    dvyukov committed Mar 20, 2019
    Use CheckoutCommit instead of SwitchCommitto get the crashing commit.
    The problem is with trees like linux-next. They require at least fetching tags
    and maybe even different tree (-history).
    Use CheckoutCommit which at least fetches tags which is enough
    for recent commits.
    
    Update #501
  7. pkg/vcs: wrap git invocations in a helper method

    dvyukov committed Mar 20, 2019
    There is a bunch of repetition to invoke git.
    Wrap it into a helper method.
  8. pkg/vcs: remove unused functions

    dvyukov committed Mar 20, 2019
    Bisect is not needed after introduction of Bisecter interface.
  9. executor: update fdio import path

    mvanotti authored and dvyukov committed Mar 20, 2019
    The Fuchsia team is going to remove the `lib/fdio/util.h` library. They
    have already moved all the functions to new header files.
    
    I have seen that fuchsia uses `fdio_service_connect`, which has been
    moved to the `lib/fdio/directory.h` header file.
    
    This commit just changes the import path in the fuchsia executor, and in
    the corresponding generated go file (I made that change by running `make
    generate`).
  10. docs, pkg/vcs, sys/fuchsia: update fuchsia urls

    mvanotti authored and dvyukov committed Mar 20, 2019
    Recently the fuchsia team decided to merge all their subrepos into one
    big git repo. This meant that the "zircon" repo doesn't exist anymore.
    Instead almost everything is under the fuchsia repo.
    
    This change updates all the reference I could find in the code that
    point to the zircon and docs repo to make them point to the new fuchsia
    repo.
  11. syz-manager: fix typo in dashboard stats upload error

    ajdlinux authored and dvyukov committed Mar 20, 2019
    Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Older
You can’t perform that action at this time.