Skip to content
Permalink
Tree: 5d9a39247f
Commits on Nov 21, 2018
  1. sys/fuchsia: update fidl mappings.

    mvanotti authored and dvyukov committed Nov 21, 2018
    This commit is just a run of make extract + make generate with an up to
    date fuchsia tree. This commit only updates the fidl definitions, there
    are some other syscalls that had changed and need to be manually updated
    (that will come in a future commit).
  2. prog: try to nullify pointers when minimizing

    xairy authored and dvyukov committed Nov 15, 2018
    This patch changes minimization routines to try assigning a.Res to nil
    for each pointer arg.
  3. docs/openbsd: as of OpenBSD 6.4, the console speed defaults to 115200

    mptre authored and dvyukov committed Nov 20, 2018
  4. pkg/compiler: add error handler in CollectUnused

    mvanotti authored and dvyukov committed Nov 21, 2018
    * pkg/compiler: Add error handler in `CollectUnused`.
    
    This commit adds an error handler for the `CollectUnused` function. The
    error handler just panics on any error, but is useful for debugging.
    
    The error handler is used any time `comp` finds an error, and if it's
    missing, it will panic due to a `nil` pointer dereference. At least now
    we get a better understanding of the errors.
    
    The only user of `CollectUnused` is `sys/fuchsia/fidlgen`, which is
    failing now and will be fixed in a future commit.
    
    The output message looks like this:
    ```
    panic: could not collect unused nodes. fidl_net-stack.txt:110:15:
    unknown type zx_chan_zircon_ethernet_Device_client
    ```
    
    * pkg/compiler Better error handling in CollectUnused
    
    This commit changes the default error handler for compiler to
    `ast.LoggingHandler`, meaning that if `nil` is passed as an error
    handler, `LoggingHandler` will be used instead.
    
    `CollectUnused` now returns an error if any of the subfunctions produce errors.
    
    `fidlgen` is the only caller of `CollectUnused`, and now checks for errors
    as well.
    
    * pkg/compiler Add tests for CollectUnused
    
    This commit adds basic tests for the CollectUnused function. There's one
    test that checks that it returns the right nodes, and another one that
    makes sure that it returns errors when needed.
    
    To make the test clearer, I had to add the error handler as an explicit
    parameter in `CollectUnunsed`, instead of using the default one. This
    avoid printing garbage in the logs. The `TestCollectUnusedError` function
    uses a nopErrorHandler to avoid printing anything.
    
    * pkg/compiler fix presubmit warnings
  5. sys/fuchsia: add zircon-ethernet to fidlgen libs

    mvanotti authored and dvyukov committed Nov 21, 2018
    This commits adds "zircon-ethernet" to the list of fidl libraries that
    fidlgen would look at. This is required because recently, a change in
    fuchsia[0] added a new method to the netstack interface, that allows for
    adding an EthernetInterface. One of the parameters is a
    zircon.ethernet.Device, so we need to import that type for fidlgen to be
    able to understand fidl_net-stack.txt.
    
    I tested this by running:
    
    ```shell
    $ make extract TARGETOS=fuchsia SOURCEDIR=${FUCHSIADIR}
    $ make generate
    ```
    
    [0]: https://fuchsia-review.googlesource.com/c/zircon/+/220580
  6. docs: require arm64 build for fuchsia

    mvanotti authored and dvyukov committed Nov 21, 2018
    I am adding a note in the fuchsia docs to specify that the caller should also build fuchsia for arm64. This is because the make extract command will call generate_fidl for TARGETARCH amd64 and arm64. If you happen to have an old tree for arm64, your amd64 changes might be overwritten by the arm64 ones.
Commits on Nov 20, 2018
  1. docs/openbsd: update found_bugs.md

    mptre authored and dvyukov committed Nov 20, 2018
  2. Fixed a tiny typo

    skoulikov authored and dvyukov committed Nov 20, 2018
  3. openbsd: enable packet injection

    Greg Steuck authored and dvyukov committed Nov 18, 2018
  4. sys/linux: update test for changed arch_prctl descriptions

    dvyukov committed Nov 20, 2018
Commits on Nov 18, 2018
  1. docs/syzbot.md: update qemu command line

    dvyukov committed Nov 18, 2018
    Match more closely GCE VMs by using scsi drive.
    Update command line arguments.
Commits on Nov 17, 2018
  1. sys: conditionally add padding argument in MakePosixMmap()

    mptre authored and dvyukov committed Nov 17, 2018
    Some targets (NetBSD and OpenBSD) have a mmap() padding argument between the
    file descriptor and offset. Make sure to omit such argument in MakePosixMmap().
    Otherwise, reproduce programs will crash at runtime since the expected mapping
    at 0x20000000 is not established.
  2. sys/linux: refine tcp_zerocopy_receive

    dvyukov committed Nov 17, 2018
    Use the new vma64 now that we have it.
  3. pkg/compiler: add vma64 type

    dvyukov committed Nov 17, 2018
    8-byte vma is needed in several places in linux descriptions.
  4. sys/linux: modernize prctl descriptions

    dvyukov committed Nov 17, 2018
    Use one syscall per command, refine arguments, etc.
  5. dashboard/config: add spec_store_bypass_disable=prctl

    dvyukov committed Nov 17, 2018
    Opens more interesting kernel surface.
  6. executor: OpenBSD network package injection

    blackgnezdo authored and dvyukov committed Nov 17, 2018
    Squash of:
    
    * Doc typo
    
    * Ported some tun related functions.
    
    * Copy vnet.txt from linux to openbsd.
    
    * Simplified syz_emit_ethernet and stubbed out vnet.txt.
    
    * Undo clang-format header sorting: headers are order sensitive.
    
    * Uniquify tap devices by pid.
    
    * clang-format off for includes
    
    * Happier clang-format.
    
    * Partially revert "Uniquify tap devices by pid."
    
    Just rely on procid magic instead of getting it from a flag.
  7. tools/syz-fmt: allow to reformat all OSes at once

    dvyukov committed Nov 17, 2018
    We forgot trusty in Makefile.
    Fix this once and for all by formatting all known targets.
  8. sys/targest: introduce target.BuildOS

    dvyukov committed Nov 17, 2018
    We can't cross-compile native binaries from just any OS to any other.
    For most OSes we can do only native compilation.
    Some can only be compiled from linux.
    To date we avoided this problem completely (mostly assumed linux build OS).
    Make this notion of what can build what explicit.
  9. sys/targets: fix build

    dvyukov committed Nov 17, 2018
  10. pkg/csource: add support for creating reproducers on OpenBSD

    mptre authored and dvyukov committed Nov 17, 2018
Commits on Nov 16, 2018
  1. [fuchsia] SSH fix and build invocation fix.

    flowerhack authored and dvyukov committed Nov 15, 2018
    SSH keys are now included at the fx clean-build config.
    
    A proper escape sequence looked weird so use a string literal to pass
    that config.
    
    Fixed some typos I found while debugging.
Commits on Nov 15, 2018
  1. vm/vmm: make sure to always end ddb commands with a newline

    mptre authored and dvyukov committed Nov 13, 2018
    Missed one in my previous commit.
  2. dashboard/config: enable more drm configs

    dvyukov committed Nov 15, 2018
    There are 2 important virtual drm drivers:
    
    CONFIG_DRM_VKMS
    CONFIG_DRM_VGEM
    
    VGEM was already enabled, enable VKMS.
    Also enable few other configs that look like
    we can potentially reach them.
  3. [fuchsia] Fix typo in Fuchsia build.

    flowerhack authored and dvyukov committed Nov 15, 2018
    Hey--so I *don't* know a particularly efficient way to test syz-ci right
    now.
    
    There's no good config I can find for just running it locally, and I
    couldn't find any good unit tests for this function in particular, and
    running it manually on a ci server isn't super-appealing since I'd have
    to clobber the configuration there to point to my repo instead of the
    canonical repo, pull from there, etc.
    
    Do you have any good ideas for testing this before it rolls out?  In
    particular I want the invocation to look exactly like:
    
    ./scripts/fx set x64 --packages garnet/packages/products/sshd --args 'extra_authorized_keys_file="//.ssh/authorized_keys"'
    
    I thought I'd escaped it properly last time, but, since I couldn't test
    it, clearly I goofed.  I *think* this does the right thing but I'd love
    a sanity check.  Thanks!
Commits on Nov 13, 2018
  1. [fuchsia] Fix Fuchsia build.

    flowerhack authored and dvyukov committed Nov 12, 2018
    * Needed to clean out the build on the main host. We switched to a
    "petal" layout which required a complete rebuild.
    
    * Update SSH interface.  SSH keys have to be set at buildtime via
    --args.
    
    * Update fvm.blk location.
Commits on Nov 12, 2018
  1. 1) making bpf_insn varlen, 2) changing bpf_generic to match the struc…

    shankarapailoor authored and dvyukov committed Nov 12, 2018
    …t definition in linux to make trace2syz generation simpler
  2. pkg/report: do not interpret reorder_kernel lines as a crash on OpenBSD

    mptre authored and dvyukov committed Nov 12, 2018
    Sometimes the reorder_kernel error message is truncated causing the current
    ignore pattern to fail. Instead, simply reject all lines containing
    `reorder_kernel' in order to reduce noisy crash reports.
  3. syz-manager: fix syscall prio page

    dvyukov committed Nov 12, 2018
    It currently crashes as we never populate mgr.prios now.
    Calculate prios on the fly instead.
    
    Fixes #797
Older
You can’t perform that action at this time.