Skip to content
Permalink
Tree: ac912200b6
Commits on Nov 26, 2018
  1. Update found_bugs.md

    dvyukov committed Nov 26, 2018
Commits on Nov 25, 2018
  1. reordering unions for trace2syz

    shankarapailoor authored and dvyukov committed Nov 24, 2018
Commits on Nov 24, 2018
  1. removing trace2syz constants

    shankarapailoor authored and dvyukov committed Nov 23, 2018
Commits on Nov 23, 2018
  1. dashboard/app: purge old repros

    dvyukov committed Nov 23, 2018
    We have some bugs with insane amount of repros.
    So many that new crashes don't show up on dashboard at all.
    Purge old repros too. There is no need to keep more than 40.
  2. dashboard/app: enlarge stats value column for manager

    dvyukov committed Nov 23, 2018
    When numbers become large, they may not fit into 100px.
  3. docs/linux: update recommended configs

    dvyukov committed Nov 23, 2018
    Mention few more tricky kernel configs that cause problems.
  4. executor: FreeBSD: fixed endian.h path

    msvoelker authored and dvyukov committed Nov 23, 2018
    The include statement for endian.h failed on FreeBSD. Changed include statement to syz/endian.h for FreeBSD.
  5. ipc: fix ProgInfo usage better

    xairy authored and dvyukov committed Nov 22, 2018
    Fix a bad fix for ProgInfo usage.
Commits on Nov 22, 2018
  1. ipc: fix ProgInfo usage

    xairy authored and dvyukov committed Nov 22, 2018
    We used to use len([]CallInfo) to check both, whether the slice is nil or
    whether its length is zero. Since ProgInfo is not a slice, we need a
    separate check for nil.
  2. dashboard/app: show managers per namespaces

    dvyukov committed Nov 22, 2018
    End users are interested for managers only for a single namespace.
    So show them per-namespace.
  3. dashboard/app: use sort.Slice

    dvyukov committed Nov 22, 2018
    Now that GAE provides a newer Go toolchain,
    we can use sort.Slice goodness.
  4. syz-manager: modernize web UI

    dvyukov committed Nov 22, 2018
    1. Use dashboard style.
    2. Allow sorting of tables.
    3. Show old crashes in grey.
    4. Use tables instead of text output for more pages.
    5. Show corpus inputs on a separate page to allow copy-pasting.
    6. Use standard JS sorting instead of custom bubble sort (much faster).
    7. Fix off-by one in table sorting.
    
    Fixes #694
  5. ipc: add ProgInfo struct

    xairy authored and dvyukov committed Nov 21, 2018
    This patch add a new struct ProgInfo that for now holds info about each
    call in a program []CallInfo, but in the future will be expanded with remote
    coverage info. Update all the callers to use the new interface as well.
  6. pkg/report: refine rcu stall detection

    dvyukov committed Nov 22, 2018
    Add another anchor frame.
  7. pkg/report: fix corrupted stack trace checking

    dvyukov committed Nov 22, 2018
    We started detecting all kernel reboots as corrupted,
    because we considered that after any "Allocated" line
    a stack trace should follow.
    Kernel boot output now contains:
    ima: Allocated hash algorithm: sha256
    and there is no stack trace after that.
    
    1. Refine stack trace regexps (we actually want to look for
    "Allocated by task PID:" lines).
    2. Don't check stacks if report format says that it
    does not contain stacks.
  8. pkg/report: add "PANIC: double fault" report format

    dvyukov committed Nov 22, 2018
    Amusing that's another kernel failure mode that we are discovering after 3 years.
    One can't even reliably understand when kernel has crashed.
    I wonder if syzkaller never hit these, or just never recognized and reported them. We will see.
    Don't even want to think about arm kernel output parsing.
Commits on Nov 21, 2018
  1. dashboard/app: show kernel commit time

    dvyukov committed Nov 21, 2018
    Show kernel commit time (author) in a hint for all kernel commit hashes.
    
    Update #473
  2. docs: add syz-ci instructions for fuchsia

    dvyukov committed Nov 21, 2018
  3. pkg/build: copy fuchsia ssh key

    dvyukov committed Nov 21, 2018
    We've lost is somewhere along the way.
  4. Review

    Greg Steuck authored and dvyukov committed Nov 21, 2018
  5. syz-repro: minor UX improvements.

    Greg Steuck authored and dvyukov committed Nov 21, 2018
  6. syz-ci: default kernel branch to master

    dvyukov committed Nov 21, 2018
  7. docs: Add fuchsia syscall update process.

    mvanotti authored and dvyukov committed Nov 21, 2018
    This commits describes the steps required to update the syscall
    descriptions in syzkaller.
  8. sys/fuchsia: update VMAR syscalls

    mvanotti authored and dvyukov committed Nov 21, 2018
    * sys/fuchsia: update vmar syscalls.
    
    In a previous zircon commit[0], the vmar related syscalls (like
    `zx_vmar_map`, `zx_vmar_protect` and `zx_vmar_allocate`) changed the
    order of their parameters, making putting the flags parameter as the
    second parameter, and renaming it to "options".
    
    This commit modifies vmars.txt so that it reflects the latest state of
    the syscalls in zircon. I also modified the usage in
    `executor/common_fuchsia.h`
    
    I ran make extract, make generate and compiled syzkaller to test this
    change.
    
    [0]: https://fuchsia-review.googlesource.com/c/zircon/+/168060
    
    * sys/fuchsia run make generate
    
    This commit is just the result of running make generate after its
    parent. This regenerates the definitions for the modified VMAR syscalls.
  9. openbsd: include process information into crashes

    Greg Steuck authored and dvyukov committed Nov 21, 2018
  10. sys/fuchsia: update fidl mappings.

    mvanotti authored and dvyukov committed Nov 21, 2018
    This commit is just a run of make extract + make generate with an up to
    date fuchsia tree. This commit only updates the fidl definitions, there
    are some other syscalls that had changed and need to be manually updated
    (that will come in a future commit).
  11. prog: try to nullify pointers when minimizing

    xairy authored and dvyukov committed Nov 15, 2018
    This patch changes minimization routines to try assigning a.Res to nil
    for each pointer arg.
  12. docs/openbsd: as of OpenBSD 6.4, the console speed defaults to 115200

    mptre authored and dvyukov committed Nov 20, 2018
  13. pkg/compiler: add error handler in CollectUnused

    mvanotti authored and dvyukov committed Nov 21, 2018
    * pkg/compiler: Add error handler in `CollectUnused`.
    
    This commit adds an error handler for the `CollectUnused` function. The
    error handler just panics on any error, but is useful for debugging.
    
    The error handler is used any time `comp` finds an error, and if it's
    missing, it will panic due to a `nil` pointer dereference. At least now
    we get a better understanding of the errors.
    
    The only user of `CollectUnused` is `sys/fuchsia/fidlgen`, which is
    failing now and will be fixed in a future commit.
    
    The output message looks like this:
    ```
    panic: could not collect unused nodes. fidl_net-stack.txt:110:15:
    unknown type zx_chan_zircon_ethernet_Device_client
    ```
    
    * pkg/compiler Better error handling in CollectUnused
    
    This commit changes the default error handler for compiler to
    `ast.LoggingHandler`, meaning that if `nil` is passed as an error
    handler, `LoggingHandler` will be used instead.
    
    `CollectUnused` now returns an error if any of the subfunctions produce errors.
    
    `fidlgen` is the only caller of `CollectUnused`, and now checks for errors
    as well.
    
    * pkg/compiler Add tests for CollectUnused
    
    This commit adds basic tests for the CollectUnused function. There's one
    test that checks that it returns the right nodes, and another one that
    makes sure that it returns errors when needed.
    
    To make the test clearer, I had to add the error handler as an explicit
    parameter in `CollectUnunsed`, instead of using the default one. This
    avoid printing garbage in the logs. The `TestCollectUnusedError` function
    uses a nopErrorHandler to avoid printing anything.
    
    * pkg/compiler fix presubmit warnings
  14. sys/fuchsia: add zircon-ethernet to fidlgen libs

    mvanotti authored and dvyukov committed Nov 21, 2018
    This commits adds "zircon-ethernet" to the list of fidl libraries that
    fidlgen would look at. This is required because recently, a change in
    fuchsia[0] added a new method to the netstack interface, that allows for
    adding an EthernetInterface. One of the parameters is a
    zircon.ethernet.Device, so we need to import that type for fidlgen to be
    able to understand fidl_net-stack.txt.
    
    I tested this by running:
    
    ```shell
    $ make extract TARGETOS=fuchsia SOURCEDIR=${FUCHSIADIR}
    $ make generate
    ```
    
    [0]: https://fuchsia-review.googlesource.com/c/zircon/+/220580
  15. docs: require arm64 build for fuchsia

    mvanotti authored and dvyukov committed Nov 21, 2018
    I am adding a note in the fuchsia docs to specify that the caller should also build fuchsia for arm64. This is because the make extract command will call generate_fidl for TARGETARCH amd64 and arm64. If you happen to have an old tree for arm64, your amd64 changes might be overwritten by the arm64 ones.
Commits on Nov 20, 2018
  1. docs/openbsd: update found_bugs.md

    mptre authored and dvyukov committed Nov 20, 2018
Older
You can’t perform that action at this time.