Skip to content
Permalink
Tree: c35ee0ea6d
Commits on Mar 29, 2019
  1. prog, pkg/compiler: fix warnings

    dvyukov committed Mar 29, 2019
    gometalinter says:
    
    pkg/compiler/consts.go:192:⚠️ internal error: no range for "n" (vetshadow)
    pkg/compiler/consts.go:197:⚠️ internal error: no range for "n" (vetshadow)
    prog/encoding.go:862:⚠️ declaration of "v" shadows declaration at prog/encoding.go:852 (vetshadow)
    
    This somehow happens only with Go1.11 but not 1.12 so wasn't detected locally.
    The prog warnings looks legit.
    The pkg/compiler warning was amusingly introduced to please golangci-lint checker,
    revert that fix for now.
  2. syz-repro: print detailed listings

    a13xp0p0v authored and dvyukov committed Mar 29, 2019
    Final reproducers are crafty. Sometimes they just stop working.
    In that case the detailed listings of the programs executed by syz-repro
    are very helpful. Let's print them at the loglevel 3.
  3. syz-ci: put build error reason into report

    dvyukov committed Mar 29, 2019
    We inline Report in bug reports, so put the build error reason there.
    Should produce much handier reports.
  4. pkg/build: shutdown bazel in case of errors too

    dvyukov committed Mar 29, 2019
  5. pkg/build: extract bazel build errors

    dvyukov committed Mar 29, 2019
    We currently manually call extractRootCause in few selected places
    to denote kernel build errors that we want to report to developers.
    The rest are considered infra errors that we don't report.
    This does not work well. We are missing fuchsia and gvisor build errors.
    Treat all external command exection failures as kernel build errors instead.
    Let's see how this works in practice.
    Also add bazel-specfic error patterns and tests.
  6. pkg/report: work around GCE console bugs

    dvyukov committed Mar 29, 2019
  7. dashboard/app: don't error on invalid emails

    dvyukov committed Mar 28, 2019
    Malformed emails constantly appear from spammers.
    But we have not seen errors parsing legit emails.
    These errors are annoying. Warn and ignore them.
  8. prog: fix a bunch of bugs in parsing

    dvyukov committed Mar 28, 2019
    Add fuzzer for Deserialize and fix 5 or so bugs it found.
    
    Fixes #1086
  9. sys/openbsd: add bpf descriptions

    mptre authored and dvyukov committed Mar 28, 2019
  10. modify

    houjingyi233 authored and dvyukov committed Mar 29, 2019
  11. pkg/build: Add ssh tools for fuchsia.

    mvanotti authored and dvyukov committed Mar 28, 2019
    This commit adds the "//bundles:tools" packages to the fuchsia build
    used for syzkaller. This includes ssh tools, which includes scp.
    
    TEST=I have tested this on syz-ci. Fuchsia is now able to pass the image
    test.
Commits on Mar 28, 2019
  1. .golangci.yml: add golangci-lint config

    dvyukov committed Mar 28, 2019
    Update #977
  2. vm/gce: allow non-preemptible VMs

    dvyukov committed Mar 28, 2019
    We are seeing some flakes during bisection and image testing.
    Hard to tell what's the root cause because they are episodic.
    But using non-preemptible VMs for bisection and image testing
    looks good on all fronts.
    
    Update #501
Commits on Mar 27, 2019
  1. AUTHORS: mention Mellanox Technologies

    dvyukov committed Mar 27, 2019
  2. update CONTRIBUTORS

    noaos authored and dvyukov committed Mar 6, 2019
    Signed-off-by: Noa Osherovich <noaos@mellanox.com>
  3. Sys/linux: Add rdma.txt

    noaos authored and dvyukov committed Dec 17, 2017
    Initial description of the kernel's RDMA subsystem.
    This patch covers most of the older write() interface as well as the
    some ioctl functions.
    Also disable rdma_cm's ib_qp_type flags as it conflicts with rdma's
    definition, and rdma builds first.
    
    Signed-off-by: Noa Osherovich <noaos@mellanox.com>
  4. sys/syz-extract: fix too long line

    dvyukov committed Mar 27, 2019
  5. docs/fuchsia: update fx set & paths in docs

    mvanotti authored and dvyukov committed Mar 25, 2019
    This commit updates the documentation for fuchsia, updating both the fx
    set commands as well as the syz-manager config example.
    
    The invocation for the fx set command changed recently. The new command
    requires the user to specify both the product and board (core.x64 and
    core.arm64), as well as the build directory (otherwise everything gets
    built into `out/default`).
    
    The changes in the syz-manager config are for it to point to the right
    files required to run a fuchsia vm.
  6. sys/sys-extract: update import path for fuchsia.

    mvanotti authored and dvyukov committed Mar 27, 2019
    Apparently, sysroot/include doesn't exist in the build-zircon path
    anymore. I changed the path in sys-extract to make it point to the
    exported sdk include path.
    
    I also ran make extract and make generate to add new fidl definitions.
    
    TEST=ran make extract and make generate.
  7. pkg/build: update fuchsia build commands.

    mvanotti authored and dvyukov committed Mar 25, 2019
    This CL changes the invocation of the `fx set` command to match the new
    format[0].
    
    This change involves removing "board" and "product" flags. Instead, now one has to use
    `fx set product.board` to get the same result. In the case of syzkaller,
    this would be "core.${ARCH}" where arch could be x64 or arm64.
    
    Also, the default build directory now is `out/default`, and for now, it
    is still not possible to have multiple archs built altogether. I set the
    build directory manually to `out/${ARCH}` (as was before). This would
    allow syzkaller to also build the kernel for arm if required.
    
    [0]: https://fuchsia.googlesource.com/fuchsia/+/b814211ab33eeb4e8f02962d5c81d042b2464ac7
    
    TEST=Tested this in syz-ci. It worked.
Commits on Mar 25, 2019
  1. pkg/html: update generated file

    dvyukov committed Mar 25, 2019
  2. dashboard/app: properly handle build failures

    dvyukov committed Mar 22, 2019
    Separate kernel and syzkaller build failures.
    Fix logic to understand when a build is fixed:
    look if kernel/syzkaller commit changes to understand
    if it's a new good build or re-upload of an old build.
    
    Fixes #1014
Commits on Mar 24, 2019
  1. pkg/report: skip memmove on linux

    dvyukov committed Mar 24, 2019
  2. dashboard/app: fix infinite emails

    dvyukov committed Mar 24, 2019
    We override crash with the crash used for bisection
    to make the information more consistent.
    However if bisection crash only have syz repro
    and there is now another crash with C repro,
    then we always think that we have not reported C repro
    and continue sending the same report again and again.
    Don't override the crash with bisection crash in such case.
  3. sys/linux: move openat to dev_rtc.txt

    shankarapailoor authored and dvyukov committed Mar 23, 2019
    move openat$rtc to rtc_dev and change return type to fd_rtc
Commits on Mar 23, 2019
  1. tools/syz-execprog: remove dead code

    mudongliang authored and dvyukov committed Mar 22, 2019
Commits on Mar 22, 2019
  1. dashboard/app: import datastore as db

    dvyukov committed Mar 22, 2019
    datastore is too long name for such widely used packages.
    Import it as db throughout. Nicely reduces line lengths.
  2. dashboard/app: mark managers as bad after 6 hours of inactivity

    dvyukov committed Mar 22, 2019
    It should not take more than 6 hours to rebuild all kernels.
    So it's better to highlight bad managers earlier.
  3. pkg/bisect: detect when too many instances errored

    dvyukov committed Mar 22, 2019
    We currently skip a commit iff all 10 instances errored.
    But if, say, only 9 errored we consider it as OK,
    but this significnalty reduces chances of detecting flaky crashes.
    So skip if more than 2/3 errored.
    
    Update #501
  4. dashboard/app: slightly relax command parsing

    dvyukov committed Mar 22, 2019
    Users have misspelled test: multiple times.
    Accept commands without the colon.
  5. syz-ci: fix filling of kernel commit in bisection jobs

    dvyukov committed Mar 22, 2019
    There is a bit of a mess: dashboard expects the start commit
    in build info, but syz-ci sends the resulting cause commit.
    Moreover for inconclusive bisection the commit is not filled at all.
    Fill start commit in build info on start.
    
    Update #501
  6. dashboard/app: add uncc command

    dvyukov committed Mar 21, 2019
    Add "#syz uncc" command as a safety handle.
    The command allows sender to unsubscribe from all future communication on the bug.
    
    Linus mentioned possibility of saying "I'm not the right person for this report"
    in the context of bug reminders:
    https://groups.google.com/d/msg/syzkaller/zYlQ-b-QPHQ/AJzpeObcBAAJ
Older
You can’t perform that action at this time.