Skip to content
Permalink
Tree: dce6e62ffc
Commits on Mar 21, 2019
  1. docs: add custom anchors to headers (2)

    dvyukov committed Mar 21, 2019
    Div's seem to work. Use them.
  2. docs: add custom anchors to headers (2)

    dvyukov committed Mar 21, 2019
    The previous attempt made things only worse... Try 2.
  3. docs: add custom anchors to headers

    dvyukov committed Mar 21, 2019
    Add shorter anchors that does not depend on actual text (subject to change).
    This allows to generate shorter stable links to docs.
    Let's see if this syntax works.
  4. pkg/build: add a test for build failure root causing

    dvyukov committed Mar 21, 2019
    Such error popped up during bisection on older kernels.
    It's already detected properly, yet build failed with just "make failed"...
    Unclear why that happened, but the test won't harm.
    
    Update #501
  5. pkg/csource: allow to ignore warnings during build

    dvyukov committed Mar 21, 2019
    Running bisection using an older repro failed with:
    
        <stdin>: In function ‘syz_mount_image.constprop’:
        <stdin>:298:3: error: argument 1 null where non-null expected [-Werror=nonnull]
        In file included from <stdin>:26:0:
        /usr/include/x86_64-linux-gnu/sys/stat.h:320:12: note: in a call to function ‘mkdir’ declared here
         extern int mkdir (const char *__path, __mode_t __mode)
    
    Let's be safe and ignore warnings during repro/bisect.
    Everything that runs during tests still has all warnings.
    
    Update #501
  6. executor: prevent non-null expected warnings

    dvyukov committed Mar 21, 2019
    The added test triggers warnings like these:
    
    <stdin>: In function ‘syz_mount_image.constprop’:
    <stdin>:298:3: error: argument 1 null where non-null expected [-Werror=nonnull]
    In file included from <stdin>:26:0:
    /usr/include/x86_64-linux-gnu/sys/stat.h:320:12: note: in a call to function ‘mkdir’ declared here
     extern int mkdir (const char *__path, __mode_t __mode)
                ^~~~~
    cc1: all warnings being treated as errors
    
    <stdin>: In function ‘syz_open_procfs.constprop’:
    <stdin>:530:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    <stdin>:532:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    <stdin>:534:41: error: ‘%s’ directive argument is null [-Werror=format-truncation=]
    <stdin>:85:110: note: in definition of macro ‘NONFAILING’
    
    Use volatile for all arguments of syz_ functions to prevent
    compiler from treating the arguments as constants in reproducers.
    
    Popped up during bisection that used a repro that previously worked.
    Update #501
  7. Makefile: fix tidy rule

    dvyukov committed Mar 21, 2019
    Building executor now requires GOOS/GOARCH macros.
  8. dashboard/app: use 12-char hash in Fixes tags

    dvyukov committed Mar 21, 2019
    @ebiggers pointed out that Fixes tags should use 12-char hash:
    https://groups.google.com/d/msg/syzkaller-bugs/yUhRrLD6T6A/3TMwOWvWAgAJ
    I can't find any documentation on this, but it looks like most
    existing tags follow this convention so use 12-char hashes.
  9. pkg/vcs: fix fuchsia's git repo directory.

    mvanotti authored and dvyukov committed Mar 20, 2019
    This commit changes the fuchsia git repo to make it point to the main
    repo instead of just "zircon".
    
    Previously, zircon had its own git repo, so syzkaller had a wrapper that
    would issue jiri commands for the whole fuchsia repo, but would just
    report commits in the zircon repo.
    
    Recently, fuchsia merged most of its repositories in just one big git
    repo. So now, zircon is part of the fuchsia git repo. I think the code
    continued working because the old zircon repo is still part of a git
    repository, so git commands worked there.
    
    The new code now doesn't have any special casing for Zircon, and now
    (almost) everything is part of the fuchsia repo. The other repos are now
    git submodules.
Commits on Mar 20, 2019
  1. pkg/report: deduplicate sctp "no chunks on the queues" reports

    markjdb authored and dvyukov committed Mar 20, 2019
  2. syz-ci: fix a typo

    dvyukov committed Mar 20, 2019
  3. pkg/vcs: fix git tag --points-at invocation

    dvyukov committed Mar 20, 2019
    Turns out older versions of git don't imply --list for --points-at and fail.
    So add --list explicitly.
    
    Update #501
  4. syz-ci: improve job loop logic

    dvyukov committed Mar 20, 2019
    1. Prevent grabbing the next job on stop with 50% probability.
    2. Don't claim jobs if another build is already in progress.
    
    Update #501
  5. dashboard/app: request test/bisect jobs separately

    dvyukov committed Mar 20, 2019
    Allow separate sets of managers for patch testing and for bisection.
    This makes things more flexible on syz-ci deployment side.
    Remove previous hacks for bisection deployment.
    
    Update #501
  6. pkg/bisect: use CheckoutCommit instead of SwitchCommit

    dvyukov committed Mar 20, 2019
    Use CheckoutCommit instead of SwitchCommitto get the crashing commit.
    The problem is with trees like linux-next. They require at least fetching tags
    and maybe even different tree (-history).
    Use CheckoutCommit which at least fetches tags which is enough
    for recent commits.
    
    Update #501
  7. pkg/vcs: wrap git invocations in a helper method

    dvyukov committed Mar 20, 2019
    There is a bunch of repetition to invoke git.
    Wrap it into a helper method.
  8. pkg/vcs: remove unused functions

    dvyukov committed Mar 20, 2019
    Bisect is not needed after introduction of Bisecter interface.
  9. executor: update fdio import path

    mvanotti authored and dvyukov committed Mar 20, 2019
    The Fuchsia team is going to remove the `lib/fdio/util.h` library. They
    have already moved all the functions to new header files.
    
    I have seen that fuchsia uses `fdio_service_connect`, which has been
    moved to the `lib/fdio/directory.h` header file.
    
    This commit just changes the import path in the fuchsia executor, and in
    the corresponding generated go file (I made that change by running `make
    generate`).
  10. docs, pkg/vcs, sys/fuchsia: update fuchsia urls

    mvanotti authored and dvyukov committed Mar 20, 2019
    Recently the fuchsia team decided to merge all their subrepos into one
    big git repo. This meant that the "zircon" repo doesn't exist anymore.
    Instead almost everything is under the fuchsia repo.
    
    This change updates all the reference I could find in the code that
    point to the zircon and docs repo to make them point to the new fuchsia
    repo.
  11. syz-manager: fix typo in dashboard stats upload error

    ajdlinux authored and dvyukov committed Mar 20, 2019
    Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Commits on Mar 19, 2019
  1. pkg/report: fix matching for traps in kernel mode

    markjdb authored and dvyukov committed Mar 19, 2019
    We already have a pattern to match "Fatal trap N: ..." panics, but the
    format of our backtraces has changed since it was added.  Add another
    pattern which correctly matches a few instances generated by syzbot.
  2. dashboard/app: report bisection results to external reporting

    dvyukov committed Mar 19, 2019
    Update #501
  3. pkg/build: copy kernel.full to the objdir after a build

    markjdb authored and dvyukov committed Mar 18, 2019
    This helps ensure that we can create coverage reports on FreeBSD.
  4. sys/targets: use kernel.full instead of kernel.debug

    markjdb authored and dvyukov committed Mar 18, 2019
    The latter contains only debug symbols and is meant to be used with the
    kernel executable.  That is, the kernel executable contains a
    .gnu_debuglink pointer to kernel.debug.  kernel.full contains
    everything, including a copy of the kernel's text section, which we want
    when enumerating __sanitizer_cov_trace_pc() calls for a coverage report.
Commits on Mar 18, 2019
  1. dashboard/app: fix a typo in comment

    dvyukov committed Mar 18, 2019
  2. sys/linux: restrict SYSLOG_ACTION_CONSOLE_LEVEL

    dvyukov committed Mar 18, 2019
    Fuzzer must not mess with console, turn it on/off, change log level, etc.
    Otherwise it turns off kernel output on console.
  3. dashboard/config: add freebsd service script

    dvyukov committed Mar 18, 2019
  4. pkg/osutil: kill subprocesses more reliably

    dvyukov committed Mar 18, 2019
    In some cases we start scp, which starts ssh,
    then kill scp but the ssh subprocess is not killed.
    As the result cmd.Wait hangs waiting for EOF on the stdout/stderr,
    which are still kept alive by ssh subprocess. But ssh just hangs forever.
    
    Create a process group for each command and kill whole process group.
    Hopefully this will help.
  5. dashboard/app: make email tests more interesting

    dvyukov committed Mar 18, 2019
    1. Mail bugs for second and third reportings to different emails
       so that it's possible to distinguish where they are actually mailed.
    2. Add bisection test where we skip bug in the second reporting.
       Bisection results should go straigth to third as well.
  6. sys/openbsd: add chflags descriptions

    mptre authored and dvyukov committed Mar 18, 2019
  7. sys/linux: Add rfkill description for Linux

    a13xp0p0v authored and dvyukov committed Mar 17, 2019
  8. Update setup_ubuntu-host_qemu-vm_x86-64-kernel.md

    skrtbhtngr authored and dvyukov committed Mar 6, 2019
    change chown to chmod
Commits on Mar 17, 2019
  1. pkg/vcs: fix too long line

    dvyukov committed Mar 17, 2019
    Also restructure because we point to this file from syzbot docs.
Older
You can’t perform that action at this time.