Skip to content
Permalink
Tree: ecb386fe6f
Commits on Oct 19, 2018
  1. sys: check that target consts are defined

    dvyukov committed Oct 19, 2018
    Currently when we get target consts with target.ConstMap["name"]
    during target initialization, we just get 0 for missing consts.
    This is error-prone as we can mis-type a const, or a const may
    be undefined only on some archs (as we have common unix code
    shared between several OSes).
    Check that all the consts are actually defined.
    The check detects several violations, to fix them:
    1. move mremap to linux as it's only defined on linux
    2. move S_IFMT to openbsd, as it's only defined and used on openbsd
    3. define missing MAP_ANONYMOUS for freebsd and netbsd
    4. fix extract for netbsd
Commits on Oct 18, 2018
  1. Added kernel config options for debian stretch

    balbassam authored and dvyukov committed Oct 18, 2018
Commits on Oct 17, 2018
  1. Pass -debug flag to runsc.

    nlacasse authored and dvyukov committed Oct 17, 2018
    As of commit 3f053259, gVisor sentry panics are no longer sent to the
    stderr for "runsc run" by default, as that stderr belongs exclusively to
    the application.
    
    As a result, syzbot never sees the gVisor panic stack trace, and is only
    reporting errors that occur when waiting for a dead sandbox.
    
    Passing the "-debug" flag to runsc will make the sentry panics visible
    to syzbot again.
  2. Update configuration.md

    mogrein authored and dvyukov committed Oct 17, 2018
    VM parameters are not defined in config.go, I've found them in qemu.go instead.
    Fix for the documentation to make it easier to find all supported parameters for qemu.
Commits on Oct 16, 2018
  1. all: fix code formatting

    dvyukov committed Oct 16, 2018
    Reformat, remove debug leftovers, fix comment style.
Commits on Oct 15, 2018
  1. tools/create-gce-image.sh: create ext4 image without journalling

    dvyukov committed Oct 15, 2018
    We don't need consistent image after reboot since we always reimage.
    We know of some use cases that don't use journalling, but don't know
    of any that use journalling.
  2. sys/linux: prohibit FAN_OPEN_PERM and FAN_ACCESS_PERM

    dvyukov committed Oct 15, 2018
    FAN_OPEN_PERM and FAN_ACCESS_PERM require the program to reply to open requests.
    If that does not happen, the program will hang in an unkillable state forever.
    See the following bug for details:
    https://groups.google.com/d/msg/syzkaller-bugs/pD-vbqJu6U0/kGH30p3lBgAJ
Commits on Oct 12, 2018
  1. Android: Add simple test harness for Sandbox

    zachriggle authored and dvyukov committed Oct 11, 2018
  2. Android: Fix sandbox implementation

    zachriggle authored and dvyukov committed Oct 11, 2018
    My test harness for this code performed some steps that are not
    performed when syz-executor is invoked directy.
    
    Specifcally, we need to operate from a directory under /data/data,
    and have the correct UID/GID set as the owner of the directory.
    
    My test harness now correctly sets these, all sandbox operations
    succeed, and loop() is invoked.
  3. docs/openbsd: update found_bugs.md

    mptre authored and dvyukov committed Aug 29, 2018
Commits on Oct 11, 2018
  1. pkg/report: improve OpenBSD output parsing

    dvyukov committed Oct 11, 2018
    OpenBSD produces \n\r for new lines and split output at 79 column.
    Handle both of these things.
  2. pkg/email, pkg/vcs: test that OpenBSD-style commits are handled

    dvyukov committed Oct 11, 2018
    OpenBSD does not use "first line is title" convention,
    so test that this is parsed properly.
    Also test that multi-line fix/dup commands are properly parsed.
  3. docs/openbsd: use qcow2 disk format in setup

    mptre authored and dvyukov committed Oct 1, 2018
  4. vm/vmm: use derived disks for VMs

    mptre authored and dvyukov committed Oct 1, 2018
    As a result, the boot time is significantly improved since there's no longer any
    need to copy the complete disk.
    
    This feature was recently committed to OpenBSD-current. Any existing base image
    used must be recreated, this time using the qcow2 disk format.
  5. tools/create-openbsd*: Support post-version flip snapshots.

    blackgnezdo authored and dvyukov committed Oct 11, 2018
      * Fixed pkg_add status checking
      * Switched to qcow2 test image
      * Minor GC
Commits on Oct 10, 2018
  1. executor: Fuchsia: Use zx_task_resume_from_exception()

    sgraham authored and dvyukov committed Oct 10, 2018
    zx_task_resume() is deprecated; switch to using
    zx_task_resume_from_exception() instead.
  2. Update setup.md

    dvyukov committed Oct 10, 2018
    Update Go instructions for newer toolchain.
    GOPATH and GOROOT are now optional, and we also need to add GOPATH/bin to PATH.
  3. Update contributing.md

    dvyukov committed Oct 10, 2018
    fix formatting
  4. pkg/report: ignore arch/.*/mm/physaddr.c as guilty file

    dvyukov committed Oct 10, 2018
    This is called from kfree in the added test.
    We already ignore everything related to kmalloc/free
    and e.g. arch/.*/mm/fault.c, so it looks reasonable
    to ignore this one too.
  5. pkg/host: improve KMEMLEAK detection

    dvyukov committed Oct 10, 2018
    EBUSY is returned when KMEMLEAK is in fact turned off,
    not when scanning is already turned off.
    That can't be recovered.
    So instead check that we can write to the file in the check
    function and give useful diagnostics.
  6. tools/syz-execprog: show host features

    dvyukov committed Oct 10, 2018
    syz-execprog -output is handy way to check what features host.Check detects.
  7. executor: tune memcg container logic

    dvyukov committed Oct 10, 2018
    The current memcg container seems to lead to lots of hangs/stalls.
    Presumably the problem is with oom_score_adj and KASAN.
    Executor process tree eats all memory and then the leaf process is killed
    but the memory is not returned to memcg due to KASAN quarantine;
    and the parent processes are protected from killing with oom_score_adj=-1000.
    As the result the kernel locks up.
    
    1. Don't use oom_score_adj=-1000. Instead bump leaf process score to 1000 (kill always).
    2. Increase size of memcg to be larger than expected KASAN quarantine size.
  8. syz-manager: don't upload failed leak repro attempts to dashboard

    dvyukov committed Oct 10, 2018
    We did not upload the crash itself, so dashboard does not know about them.
  9. dashboard/app: make build upload more robust

    dvyukov committed Oct 10, 2018
    Currently it triggers datastore timeouts episodically.
    Don't fail build upload if bug commit update fails.
    Split the large query into two smaller queries.
  10. dashboard/app: fetch bugs in batches

    dvyukov committed Oct 2, 2018
    We are seeing lots of datastore timeout errors during bug fetch.
    It's a bad idea to fetch thousands of bugs in one query,
    so fetch them in batches of 1000 bugs.
    Hopefully will reduce rate of errors.
  11. Update fidlgen to keep current with upstream.

    flowerhack authored and dvyukov committed Oct 2, 2018
    The Syzkaller IR upstream has been updated, so we can properly update
    consts/fidl descriptions now.
  12. targets: Use OS=linux when GOOS=android

    zachriggle authored and dvyukov committed Oct 8, 2018
    This avoids the issue of "android" not having any registered configurations
    or syscalls / ioctls / etc, when built with GOOS=android.
    
    This occurs when building in Google3, since --config=android_arm64 selects
    the Android toolchain.
Commits on Oct 3, 2018
  1. docs: Update package names for modern Ubuntu

    kees authored and dvyukov committed Oct 2, 2018
    The package names for perf and qemu are out of date. This updates them.
Commits on Oct 2, 2018
  1. Include generate_fidl as part of the `extract` step.

    flowerhack authored and dvyukov committed Sep 29, 2018
    Anytime we're running `make extract/generate` with Fuchsia as a target, we
    probably want to update FIDL descriptions too, so we don't fall behind
    what upstream is up to.
    
    This includes generate_fidl as part of the `make extract` workflow.
    
    Also, corrects fidlgenPath to properly find the path for ARM targets (we
    only have host_x64 right now).
  2. kmsan: add kmsan_from_kasan_config.sh to generate KMSAN config

    ramosian-glider authored and dvyukov committed Oct 2, 2018
Commits on Oct 1, 2018
  1. docs: fix typo in reproduction documentation

    pchaigno authored and dvyukov committed Oct 1, 2018
  2. Update syzbot.md

    dvyukov committed Oct 1, 2018
  3. docs/openbsd: improve setup instructions

    mptre authored and dvyukov committed Sep 30, 2018
    The majority of the changes are prodded by Klemens Nanni, another fellow OpenBSD
    hacker.
  4. docs: mention OpenBSD

    mptre authored and dvyukov committed Sep 30, 2018
Older
You can’t perform that action at this time.