Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard/app: build bugs are not shown sometimes #1014

Closed
dvyukov opened this issue Feb 22, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@dvyukov
Copy link
Collaborator

commented Feb 22, 2019

The red bug about broken build in managers table is not always shown.
The problem is that managers can upload a new working build even when build at HEAD is broken.
This happens when a manager simply restarts, it uploads the working build again. This is handled by the isNewBuild logic here:

if isNewBuild {
err := updateManager(c, ns, req.Manager, func(mgr *Manager, stats *ManagerStats) {
mgr.CurrentBuild = req.ID
mgr.FailedBuildBug = ""
})
if err != nil {
return nil, err
}
}

But a manager can also upload a genuine new build too. Build is a combination of kernel+syzkaller, so even if kernel is broken, but syzkaller is updated, this produces a new build and it clears the "build bug" for the manager.
Need to figure out a better condition for when build can be considered repaired.

@dvyukov

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 22, 2019

@dvyukov dvyukov closed this in 52a20ba Mar 25, 2019

@dvyukov

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 25, 2019

@mvanotti @flowerhack This should improve build status monitoring. Now you can see how old is the kernel build right in the instance table. And kernel and syzkaller build failures are separated. And they should be properly "sticky", i.e. don't appear and disappear all the time.

@mvanotti

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

I just noticed this in the dashboard... THANKS!!!! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.