Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prog: more readable serialization for strings #792

Closed
dvyukov opened this issue Nov 7, 2018 · 2 comments
Closed

prog: more readable serialization for strings #792

dvyukov opened this issue Nov 7, 2018 · 2 comments

Comments

@dvyukov
Copy link
Collaborator

dvyukov commented Nov 7, 2018

Dominique Martinet reported at:
https://groups.google.com/d/msg/syzkaller-bugs/axCkZsIU5KI/C4NDCPRtAwAJ

the C reproducer (
https://syzkaller.appspot.com/x/repro.c?x=1701f831400000 ) has a lot of
"readable" letters spelled out as "\x63..." or chars as 0x3d - it's fine
for generated code and that might be easier for the intermediate
representation syzkaller works with, but do you know something handy
that would help convert these to readable strings?
e.g. "\x63\x61\x63\x68\x65\x3d\xc0\x6d\x61\x70" could be written
"cache=\xc0map", and 0x3d as '=' (hm I guess the later would not always
make sense to convert so probably best left as is, but it gets annoying
pretty fast with longer strings)

We now have readable format for strings:
dvyukov@06456ca
but it is used only if the whole string is readable. We could use it more widely.

And need to ensure that pkg/csource also generates readable strings.

@martinetd
Copy link

(I'll blindly trust you on this), thanks!

@dvyukov
Copy link
Collaborator Author

dvyukov commented Dec 16, 2018

I re-generated the original program with this change and it contained the desired "cache=\xc0map". You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants