Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile #1

Merged
merged 1 commit into from Oct 13, 2015

Conversation

Projects
None yet
2 participants
@xairy
Copy link
Collaborator

commented Oct 12, 2015

No description provided.

@@ -0,0 +1,8 @@
*.swp

This comment has been minimized.

Copy link
@dvyukov

dvyukov Oct 12, 2015

Collaborator

please also add:
*~

This comment has been minimized.

Copy link
@xairy

xairy Oct 12, 2015

Author Collaborator

Done.

This comment has been minimized.

Copy link
@dvyukov

dvyukov Oct 13, 2015

Collaborator

add yourself to CONTRIBUTORS in this patch

This comment has been minimized.

Copy link
@xairy

xairy Oct 13, 2015

Author Collaborator

Done.

.gitignore Outdated
@@ -0,0 +1,8 @@
*.swp

executor/executor

This comment has been minimized.

Copy link
@dvyukov

dvyukov Oct 12, 2015

Collaborator

please remove this and the following
we need to systemize process instead

This comment has been minimized.

Copy link
@xairy

xairy Oct 12, 2015

Author Collaborator

Added a simple Makefile, which puts all the binaries into the bin folder.

@xairy xairy force-pushed the gitignore branch 5 times, most recently from ebe0665 to d9de025 Oct 12, 2015

@xairy xairy changed the title Add .gitignore Add Makefile Oct 12, 2015

Makefile Outdated

.PHONY: all format clean master manager fuzzer executor

all: master manager fuzzer executor

This comment has been minimized.

Copy link
@dvyukov

dvyukov Oct 13, 2015

Collaborator

also need to add 'mkdir -p bin' somewhere
if I checkout a project and make fails, it makes me sad

This comment has been minimized.

Copy link
@xairy

xairy Oct 13, 2015

Author Collaborator

The folder is created automatically right now, but I added mkdir anyway, just in case.

Makefile Outdated
.PHONY: all format clean master manager fuzzer executor

all: master manager fuzzer executor

This comment has been minimized.

Copy link
@dvyukov

dvyukov Oct 13, 2015

Collaborator

also copy ./manager/example.cfg to ./manager.cfg, so that system is ready to go after make
there must a cp flag that does not overwrite existing files (and don't fail at the same time)
or you want it to go to some special dir, so that it does not show up in 'git status'? if so, we need to figure out where to put config files (master will probably also switch to config file)

This comment has been minimized.

Copy link
@xairy

xairy Oct 13, 2015

Author Collaborator

I'm not sure if it make sense to copy config files from make.
A user will need to edit it anyway, and the instructions in README are explicit enough.

@xairy xairy force-pushed the gitignore branch 2 times, most recently from 46c97ae to f1babd8 Oct 13, 2015

@dvyukov

This comment has been minimized.

Copy link
Collaborator

commented Oct 13, 2015

Looks good. But you need to merge with latest changes.
Probably README has changed.

@xairy xairy force-pushed the gitignore branch from f1babd8 to 87a42c4 Oct 13, 2015

@xairy

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 13, 2015

Done.

dvyukov added a commit that referenced this pull request Oct 13, 2015

@dvyukov dvyukov merged commit 379b657 into master Oct 13, 2015

@xairy xairy deleted the gitignore branch Oct 13, 2015

@iron-phoenix iron-phoenix referenced this pull request Aug 15, 2016

Closed

Build bug #54

@nessusmonkey nessusmonkey referenced this pull request Apr 5, 2017

Closed

GPF Null pointer deref #152

dvyukov added a commit that referenced this pull request Nov 7, 2017

vm/gce: fix error formatting
This is detected with newer Go toolchain:

vm/gce/gce.go:376: Errorf format %v reads arg #1, but call has only 0 args
vm/gce/gce.go:381: Errorf format %v reads arg #1, but call has only 0 args

blackgnezdo added a commit to blackgnezdo/syzkaller that referenced this pull request Jan 12, 2019

sys/openbsd: avoid /dev/fd node creation
Prevents corpus explosion with corrupted coverage data.

The two parallel runs of:
`doas ./syz-execprog -cover -coverfile /tmp/{fixed,unfixed} r.syz`
show markedly different coverage pictures:

unfixed:
```
2019/01/12 13:55:38 parsed 1 programs
2019/01/12 13:55:38 executed programs: 0
2019/01/12 13:55:38 call #0: signal 821, coverage 2438
2019/01/12 13:55:38 call google#1: signal 243, coverage 1363
2019/01/12 13:55:38 call google#2: signal 502, coverage 1993
2019/01/12 13:55:38 call google#3: signal 15, coverage 44
2019/01/12 13:55:38 call google#4: signal 335, coverage 8196
```

fixed:
```
2019/01/12 13:51:57 parsed 1 programs
2019/01/12 13:51:57 executed programs: 0
2019/01/12 13:51:57 call #0: signal 837, coverage 2491
2019/01/12 13:51:57 call google#1: signal 241, coverage 1341
2019/01/12 13:51:57 call google#2: signal 27, coverage 61
2019/01/12 13:51:57 call google#3: signal 13, coverage 44
2019/01/12 13:51:57 call google#4: signal 39, coverage 299
```

The contents of `r.syz` is
```
mknod(&(0x7f0000000180)='./file0\x00', 0x2006, 0x10000016e8)
r0 = open(&(0x7f0000000100)='./file0\x00', 0x0, 0x0)
mmap(&(0x7f0000000000/0x3000)=nil, 0x3000, 0x2, 0x10, r0, 0x0, 0x0)
writev(0xffffffffffffffff, &(0x7f0000002480)=[{&(0x7f0000001480)="<junk>", 0x573}], 0x1)
lstat(&(0x7f0000000240)='./file0\x00', &(0x7f0000000000))
```

So, it's the final lstat which was getting that extra coverage.  In
particular, the end of unfixed.4 has some 4734 values
0xffffffff00000000.

dvyukov added a commit that referenced this pull request Jan 14, 2019

sys/openbsd: avoid /dev/fd node creation
Prevents corpus explosion with corrupted coverage data.

The two parallel runs of:
`doas ./syz-execprog -cover -coverfile /tmp/{fixed,unfixed} r.syz`
show markedly different coverage pictures:

unfixed:
```
2019/01/12 13:55:38 parsed 1 programs
2019/01/12 13:55:38 executed programs: 0
2019/01/12 13:55:38 call #0: signal 821, coverage 2438
2019/01/12 13:55:38 call #1: signal 243, coverage 1363
2019/01/12 13:55:38 call #2: signal 502, coverage 1993
2019/01/12 13:55:38 call #3: signal 15, coverage 44
2019/01/12 13:55:38 call #4: signal 335, coverage 8196
```

fixed:
```
2019/01/12 13:51:57 parsed 1 programs
2019/01/12 13:51:57 executed programs: 0
2019/01/12 13:51:57 call #0: signal 837, coverage 2491
2019/01/12 13:51:57 call #1: signal 241, coverage 1341
2019/01/12 13:51:57 call #2: signal 27, coverage 61
2019/01/12 13:51:57 call #3: signal 13, coverage 44
2019/01/12 13:51:57 call #4: signal 39, coverage 299
```

The contents of `r.syz` is
```
mknod(&(0x7f0000000180)='./file0\x00', 0x2006, 0x10000016e8)
r0 = open(&(0x7f0000000100)='./file0\x00', 0x0, 0x0)
mmap(&(0x7f0000000000/0x3000)=nil, 0x3000, 0x2, 0x10, r0, 0x0, 0x0)
writev(0xffffffffffffffff, &(0x7f0000002480)=[{&(0x7f0000001480)="<junk>", 0x573}], 0x1)
lstat(&(0x7f0000000240)='./file0\x00', &(0x7f0000000000))
```

So, it's the final lstat which was getting that extra coverage.  In
particular, the end of unfixed.4 has some 4734 values
0xffffffff00000000.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.