Embed ipv4 checksums #117
Merged
Embed ipv4 checksums #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvyukov
reviewed
Jan 25, 2017
| @@ -197,6 +197,8 @@ func (p *Prog) Mutate(rs rand.Source, ncalls int, ct *ChoiceTable, corpus []*Pro | |||
| p.replaceArg(c, arg, arg1, calls) | |||
| case *sys.LenType: | |||
| panic("bad arg returned by mutationArgs: LenType") | |||
| case *sys.CsumType: | |||
| panic("bad arg returned by mutationArgs: LenType") | |||
|
All done, PTAL |
dvyukov
reviewed
Jan 25, 2017
| bfLen := uint64(arg.Type.BitfieldLength()) | ||
| switch arg.Size() { | ||
| case 1: | ||
| storeByBitmask8((*uint8)(addr), uint8(arg.Value(pid)), bfOff, bfLen) |
There was a problem hiding this comment.
Please also declare val := arg.Value(pid) outside of the switch.
dvyukov
reviewed
Jan 25, 2017
| return csumField, &newCsumField | ||
| } | ||
|
|
||
| func calcChecksumsArray(args []*Arg, pid int) map[*Arg]*Arg { |
There was a problem hiding this comment.
Please inline this into calcChecksumsCall as that's the only caller.
dvyukov
reviewed
Jan 25, 2017
| } | ||
|
|
||
| func calcChecksumsArray(args []*Arg, pid int) map[*Arg]*Arg { | ||
| m := make(map[*Arg]*Arg) |
There was a problem hiding this comment.
Declare it as var m map[*Arg]*Arg and then in the loop:
if m == nil {
m = make(map[*Arg]*Arg)
}
This will remove memory allocation from hot path in expected case when there are no checksums.
|
Otherwise LGTM |
This change adds a `csum[kind, type]` type. The only available kind right now is `ipv4`. Using `csum[ipv4, int16be]` in `ipv4_header` makes syzkaller calculate and embed correct checksums into ipv4 packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.