Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pure Numpy backend #55

Closed
chaserileyroberts opened this issue May 16, 2019 · 3 comments
Closed

Add pure Numpy backend #55

chaserileyroberts opened this issue May 16, 2019 · 3 comments
Assignees
@stavros11
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chaserileyroberts
Copy link
Contributor

Add a pure numpy backend once #52 is merged.
@chaserileyroberts chaserileyroberts added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 16, 2019
@stavros11
Copy link
Contributor

stavros11 commented May 17, 2019 •
edited

I have some progress on this, it seems that it should not be much different from the tensorflow backend. What is the current plan? Are we waiting for feedback on #52 or do we need the numpy one to change the tests? Currently I can test my numpy locally by modifying tensornetwork_test.py (changing some tf.ones to np.ones and removing the eager related tests) but we will probably have general backend-independent tests at some point.

@chaserileyroberts
Copy link
Contributor Author

Awesome!

Just wait for #52 to be merged. Then we can merge your numpy backend and change the tests.

@chaserileyroberts
Copy link
Contributor Author

If you want to do some stuff today, you can replace the tf with np when possible and move the tensorflow specific tests into the graphmode test file.

@stavros11 stavros11 mentioned this issue May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stavros11 stavros11

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaserileyroberts @stavros11