Start containers at the end of deployment #1925
Conversation
| echo "2. docker-compose up -d" | ||
| docker-compose up -d |
There was a problem hiding this comment.
I'm not sure everyone wants to automatically start the containers. Could we put this behind a flag instead?
--start-containers
There was a problem hiding this comment.
Where do input this flag? Can we ask user whether to start container after installation is done?
There was a problem hiding this comment.
I think both would be fine:
sh deploy_timesketch.sh —start-container
Or if that is not set at the end of the script ask
Would you like start your container (y/n) [default:no]
What do you think @avitomar12 ?
There was a problem hiding this comment.
Yes. I also think its better to provide both options to the user.
| echo "3. docker-compose exec timesketch-web tsctl add_user --username <USERNAME>" | ||
| #input the username | ||
| read -p 'USERNAME : ' USRNAME |
There was a problem hiding this comment.
Should that be s/USRNAME/USERNAME?
|
Friendly ping @avitomar12 - please let us know the status of this PR and if you plan to update it. |
berggren
changed the title
|
@avitomar12 Friendly ping |
|
@avitomar12 Ping again - please see the comments in the review. If we don't hear back we need to close this PR for the time being (we can open it again if needed later). |
@berggren I am working on it. I will make change within two days. |
Hello again, any progress on this PR? |
|
I'm closing this PR out of lack of updates. Please reopen if you get a chance to pick this up again. |
This PR resolve the issue #1840 . Added code to start the container.