Proposed fix for Export Sketch feature which was not working. #2316
Conversation
|
Note that returned the wrong index. It was just a 1 digit int. So i replaced it with Not sure if this is the best way to do it, and also could find the origin of the wrong index number in the query_filter. hence this is just a Proposal, and will be waiting for input regarding this. |
| indices = query_filter.get("indices", self.sketch_indices) | ||
| if not indices or "_all" in indices: | ||
| indices = self.sketch_indices | ||
| indices = self.sketch_indices |
There was a problem hiding this comment.
I know that this is already merged, but this block means that the saved search will be wrong in the case that the filter has specific indices selected, and will potentially return unexpected result, which is probably not what we want?
There was a problem hiding this comment.
ping @jaegeral who reviewed this PR
There was a problem hiding this comment.
Ya, i mentioned this in the comment above.
"Not sure if this is the best way to do it, and also could find the origin of the wrong index number in the query_filter. hence this is just a Proposal, and will be waiting for input regarding this."
There was a problem hiding this comment.
There is something wrong with
query_filter = json.loads(view.query_filter)
indices = query_filter.get("indices", self.sketch_indices)
Not sure where is the index in the query filter is set. it returned the wrong index. It was just a 1 digit int. If you have any pointers I can try debug this.
Please provide enough information so that others can review your pull request:
This PR fixes a bug in the Sketch Export feature.
Checks
Closing issues
closes #2315