Proposed fix for Export Sketch feature which was not working.

[hkhalifa]

Please provide enough information so that others can review your pull request:

This PR fixes a bug in the Sketch Export feature.

Checks

• All tests succeed.
• Unit tests added.
• e2e tests added.
• Documentation updated.

Closing issues
closes #2315

[hkhalifa]

Note that

query_filter = json.loads(view.query_filter)
indices = query_filter.get("indices", self.sketch_indices)

returned the wrong index. It was just a 1 digit int. So i replaced it with

indices = self.sketch_indices

Not sure if this is the best way to do it, and also could find the origin of the wrong index number in the query_filter. hence this is just a Proposal, and will be waiting for input regarding this.

[jaegeral]

Thx for the fix

[berggren]

I know that this is already merged, but this block means that the saved search will be wrong in the case that the filter has specific indices selected, and will potentially return unexpected result, which is probably not what we want?

[berggren]

ping @jaegeral who reviewed this PR

[hkhalifa]

Ya, i mentioned this in the comment above.

"Not sure if this is the best way to do it, and also could find the origin of the wrong index number in the query_filter. hence this is just a Proposal, and will be waiting for input regarding this."

[hkhalifa]

There is something wrong with

query_filter = json.loads(view.query_filter)
indices = query_filter.get("indices", self.sketch_indices)

Not sure where is the index in the query filter is set. it returned the wrong index. It was just a 1 digit int. If you have any pointers I can try debug this.