Skip to content

Search history tree generation #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Search history tree generation #2320

merged 3 commits into from
Sep 7, 2022

Conversation

berggren
Copy link
Contributor

@berggren berggren commented Sep 6, 2022

The History tree used a naive approach to find a reasonable root node to generate the tree from. In some edge cases, the last node was not present in the tree and the UI failed to render the history.

This PR changes so we always start from the last node, and then traverse backwards in the tree 10 nodes. After that generate the full sub tree with all children etc.

@berggren berggren requested a review from jkppr September 6, 2022 21:01
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit 7b8b242 into master Sep 7, 2022
@berggren berggren deleted the history-bug branch September 7, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants