Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual event #2321

Merged
merged 14 commits into from
Sep 12, 2022
Merged

Add manual event #2321

merged 14 commits into from
Sep 12, 2022

Conversation

marcobrotto
Copy link
Contributor

Add a manual event in Timesketch V2

This PR is the continuation of PR #2304: it solves the issue of creating a new manual event correlated to an existing timeline event at the bottom of the page.

In the previous version, the pop-up to insert a manual event was always displayed at the top of the page. To this end, if the user wanted to insert a manual event correlated to an event at the bottom of the page, then the pop-up was not shown on the screen. In the next figure, by clicking on the selected button, the pop-up to insert a manual event is not shown on the screen because it is created at the top of the page.

Screenshot 2022-09-09 11 07 16 AM

We cope with this limitation by opening a dialog page instead of a pop-up at the top of the page: in this way the user can always watch the dialog window independently from the selected event.

image

@jaegeral jaegeral merged commit 4397595 into google:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants