Merged
Conversation
Add formatting python files documentation
Co-authored-by: Thomas Chopitea <tomchop@gmail.com>
jaegeral
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a manual event in Timesketch V2
This PR is the continuation of PR #2304: it solves the issue of creating a new manual event correlated to an existing timeline event at the bottom of the page.
In the previous version, the pop-up to insert a manual event was always displayed at the top of the page. To this end, if the user wanted to insert a manual event correlated to an event at the bottom of the page, then the pop-up was not shown on the screen. In the next figure, by clicking on the selected button, the pop-up to insert a manual event is not shown on the screen because it is created at the top of the page.
We cope with this limitation by opening a dialog page instead of a pop-up at the top of the page: in this way the user can always watch the dialog window independently from the selected event.