Merged
Conversation
marcobrotto
requested review from
berggren and
jaegeral
and removed request for
berggren
berggren
approved these changes
Sep 21, 2022
timesketch/frontend-ng/src/components/Explore/FormatXMLString.vue
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML Viewer for xml_string attribute (second version with PRE HTML tag)
Plaso can parse WINEVTX logs. It creates an attribute
xml_stringthat is the "dump" of the log itself. The next figure shows how it is represented in Timesketch.This valuable information might be hard to interpret since it is written in a compat format. With this PR we aim to create an icon to visualize better this attribute.
Frontend files modified:
EventDetail.vue: added the icon (</>) for the attributexml_stringFormatXMLString.vue: new component to display the XML string. It receives as input (~ property) the xml_string of the event's attributexml_string. It outputs a formatted version ofxml_stringAreas of improvements
We add the xml button to view the XML only when the attribute in the timeline event is equal to
xml_string. This assumption works fine for the majority of the winevtx file parsed with Plaso. We could add the same button for whatever attribute that contains some XML.Differences with the previous PR #2325
In this PR the component
FormatXMLStringembeds thexml_stringinto apretag. The code is very short and it could be ported intoEventDetail.vue. We left it in a separate file because the component could have more feature and capabilities in the future.