Skip to content

Updated Sigma support in the API client#2333

Merged
berggren merged 10 commits into
google:masterfrom
jaegeral:2301_apiclient
Sep 27, 2022
Merged

Updated Sigma support in the API client#2333
berggren merged 10 commits into
google:masterfrom
jaegeral:2301_apiclient

Conversation

@jaegeral

@jaegeral jaegeral commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Update the JS API client to add recent additions of the File based API
  • replace the term es_query with query_string to be consistent with the rest of the codebase
  • make API client methods deprecated that will soon be gone away as they link to the file based API
  • add methods in the API client that talk to the databased Sigma Rule API

This is a next step to: #2301

@jaegeral jaegeral marked this pull request as ready for review September 19, 2022 14:25
@jaegeral jaegeral requested a review from berggren September 20, 2022 08:19
@jaegeral jaegeral mentioned this pull request Sep 20, 2022
Closed
23 tasks
@berggren berggren changed the title 2301 apiclient Updated Sigma support in the API client Sep 22, 2022
@jaegeral jaegeral requested review from jkppr and removed request for berggren September 23, 2022 09:15
berggren
berggren requested changes Sep 26, 2022
View reviewed changes

@berggren berggren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Comment thread api_client/python/timesketch_api_client/client.py Outdated
Comment thread api_client/python/timesketch_api_client/client.py Outdated
Comment thread api_client/python/timesketch_api_client/client.py Outdated
Comment thread api_client/python/timesketch_api_client/sigma.py Outdated
@jaegeral jaegeral requested a review from berggren September 27, 2022 11:18
jkppr
jkppr approved these changes Sep 27, 2022
View reviewed changes

@jkppr jkppr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

berggren
berggren approved these changes Sep 27, 2022
View reviewed changes

@berggren berggren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berggren berggren merged commit 64c4337 into google:master Sep 27, 2022
@berggren berggren deleted the 2301_apiclient branch September 27, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berggren berggren berggren approved these changes

@jkppr jkppr jkppr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaegeral @berggren @jkppr