Fix double escaping in sigma_util causing yaml.parser.ParserError #3028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #3027, by simply passing the text of a sigma rule (
rule_text
instead of it's already escaped versiondoc
) tosigmatools
.sigmatools
does the parsing and escaping of yaml by itself.yaml.safe_load_all
is still used for yaml-parsing (making sure, that the format is right) within this function, before calling thesigmatools
library.Like mentioned in the issue, the previous version led to ParserErrors, due to "double escaping" via
yaml.safe_load_all
in specific cases.The PR also fixes one
sigma_util.py
test, which was failing mistakenly.Checks
Closing issues
closes #3027