Skip to content

Improve `String.prototype.contains` polyfill #556

Merged
merged 1 commit into from Dec 17, 2013

2 participants

@mathiasbynens

This patch replaces the old String.prototype.contains polyfill with http://mths.be/contains, while also adding the tests from that project.

@mathiasbynens mathiasbynens Improve `String.prototype.contains` polyfill
This patch replaces the old `String.prototype.contains` polyfill with http://mths.be/contains, while also adding the tests from that project.
18c5d55
@arv
arv commented Dec 17, 2013

LGTM

I didn't know that contains takes a position param. I guess it makes sense even though I don't think we should have added the position parameters to these in the first place.

@arv arv merged commit 18c5d55 into google:master Dec 17, 2013

1 check passed

Details default The Travis CI build passed
@mathiasbynens mathiasbynens added a commit to mathiasbynens/String.prototype.includes that referenced this pull request Dec 18, 2013
@mathiasbynens mathiasbynens README: Note that Traceur now uses this polyfill 28b879f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.