Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed_info.feed_contact_email and feed_contact_url #31

Merged
merged 2 commits into from Aug 22, 2018

Conversation

@antrim
Copy link
Contributor

commented Nov 24, 2016

@googlebot googlebot added the cla: yes label Nov 24, 2016
@barbeau

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2016

@antrim Do you know if we have any consumers for these fields yet?

@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2016

Good question. There are no consuming applications that I know of. I also ran a quick search in the Transitland Datastore code (https://github.com/transitland/transitland-datastore/search?q=contact). Data in these fields may still be used by people who download the feed and open feed_info.txt. If people do that, I'd argue we could call that a consuming "application". This is likely the case with other fields in feed_info.txt.

@barbeau

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2016

I opened an issue for adding this to OneBusAway at OneBusAway/onebusaway-application-modules#192 - it may address a use case we were recently discussing.

@LeoFrachet

This comment has been minimized.

Copy link
Collaborator

commented Jan 11, 2017

+1 for those changes

@drewda drewda referenced this pull request Jan 13, 2017
3 of 3 tasks complete
@drewda

This comment has been minimized.

Copy link

commented Jan 13, 2017

+1 and Transitland can be a consumer: transitland/transitland#203

@LeoFrachet

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2018

I'm calling for the vote, since the conversation faded out, and we have the required producer & consumer:

Vote is closing on Wednesday, Aug 15th, at 23:59:59 UTC.

[Edited to add MBTA]

@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2018

+1 on behalf of @trilliumtransit.

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@googlebot googlebot added cla: no and removed cla: yes labels Aug 8, 2018
@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2018

I signed it!

@drewda

This comment has been minimized.

Copy link

commented Aug 8, 2018

Transitland does consume these fields, and I'm glad to +1 again on behalf of @transitland and @interline-io.

@barbeau

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2018

+1 on behalf of @CUTR-at-USF

@antrim There is a merge conflict with this PR and the master branch - could you resolve this? I'm guessing (hoping) that this doesn't alter the text of this proposal so the vote can continue.

@evantrillium

This comment has been minimized.

Copy link

commented Aug 8, 2018

I am working on this on behalf of @antrim to suss out what the issue is. I'll post any questions I run into here.

@mgilligan

This comment has been minimized.

Copy link

commented Aug 8, 2018

+1, TriMet's GTFS includes feed_contact_url

@gcamp

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

+1 on behalf of @TransitApp

@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2018

@evantrillium Is working to resolve the merge conflict.

@AntoineGrapperon

This comment has been minimized.

Copy link

commented Aug 10, 2018

+1 on behalf of INRO Software (consumer of GTFS data)

@skinkie

This comment has been minimized.

Copy link

commented Aug 10, 2018

@LeoFrachet Could the voting proces please be announced in the Google Group as the proces @barbeau described before?

+1

@LeoFrachet

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2018

@skinkie: Thanks for pointing this out! It's a good point and I'll do it in the future!

Side note (pinging @barbeau): I re-read the CHANGES.md last week before opening the vote and opening the other Pull Request, and I didn't saw this part. I saw only that we should send a message in the Google Group when an issue/PR is opened, not when the vote is opened. So if it is something that we want to add, another PR should be open to edit the CHANGES.md accordingly.

@DaveBarker

This comment has been minimized.

Copy link

commented Aug 13, 2018

+1

@LeoFrachet

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2018

Vote is closed.

In favor:

Against:
[nobody]

So we have:

=> The proposal is therefore adopted.

=> @barbeau: Could you check that I counted the 7 days the good way? (Just to be sure…)

Then, when merging, we should also update the Revision History in CHANGES.md

@LeoFrachet

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2018

@antrim: Could you sign the CLA so that it could be merged?

@barbeau

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2018

@LeoFrachet Dates look good to me! I've also opened a new issue at #96 for adding the announcement of votes on the GTFS Changes group.

@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2018

I signed the agreement for Google Contributor License Agreement for Trillium Solutions, Inc. on 10/27/2016.

@antrim

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 22, 2018
@LeoFrachet LeoFrachet merged commit e3475d6 into google:master Aug 22, 2018
1 check passed
1 check passed
cla/google All necessary CLAs are signed
carletop added a commit to ODOT-PTS/GTFS-ride that referenced this pull request Oct 3, 2018
* The change to GTFS during the review period (google/transit#31), which allows for additional fields in feed_info.txt, does not affect the functionality of GTFS-ride.
* There were no changes to GTFS-ride.
@carletop carletop referenced this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.